fix: spawn GetToolDefs to avoid blocking actor loop#1579
Closed
joaquinhuigomez wants to merge 1 commit into0xPlaygrounds:mainfrom
Closed
fix: spawn GetToolDefs to avoid blocking actor loop#1579joaquinhuigomez wants to merge 1 commit into0xPlaygrounds:mainfrom
joaquinhuigomez wants to merge 1 commit into0xPlaygrounds:mainfrom
Conversation
Wrap dynamic_tools in Arc and spawn GetToolDefs handler to a separate task, matching the existing CallTool pattern. This prevents vector store I/O from blocking the actor loop and starving concurrent messages.
Contributor
|
@joaquinhuigomez Hey there, please run |
Closed
1 task
Contributor
|
Replaced by #1607 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1573 (Issue 2)
GetToolDefswith a prompt awaits vector store I/O inline in the actor loop, blocking all concurrent messages (CallTool,AddTool, etc.) for the duration of the round-trip.CallToolalready avoids this by spawning to a separate task.Changes
dynamic_toolsinArcso it can be shared with spawned tasksGetToolDefshandler to a separate task, matching the existingCallToolpatternget_tool_definitionsinto a free function that takes owned/shared references instead of&mut selfToolErrorresponse variant inToolServerHandle::get_tool_defsTest plan
tool::servertests pass (includingtest_toolserver_dynamic_tools)dynamic_toolsfield is private,Arcwrapping is internal