Jhilliard/agglayer authorized signers #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Not sure if this will work, but I can see some signs that the current processes is not reliable. This failure for example: https://github.com/0xPolygon/kurtosis-cdk/actions/runs/8507920924/job/23300629115?pr=38 Basically we're getting a temporarily unavailable error when trying to run: ```bash sudo add-apt-repository ppa:rmescandon/yq sudo apt update sudo apt install --yes yq ```
|
minhd-vu
approved these changes
Apr 1, 2024
leovct
reviewed
Apr 2, 2024
| @@ -2,6 +2,9 @@ | |||
| # TODO switch this to permissionless | |||
| 1 = "http://zkevm-node-rpc{{.deployment_suffix}}:{{.zkevm_rpc_http_port}}" | |||
|
|
|||
| [ProofSigners] | |||
| # 1 = "{{.zkevm_l2_proofsigner_address}}" | |||
There was a problem hiding this comment.
Q: Why is this section commented on?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates the changes from agglayer/agglayer-go#110 in order to be able to support custom proof signers.
Additionally, this PR includes a small change to hopefully standardize around the same implementation of
yqwithin the repo