Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/x] feature(frontend): generate synthetic functions with Miden ABI transformation (stdlib, tx_kernel); #412

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

greenhat
Copy link
Contributor

@greenhat greenhat commented Feb 21, 2025

#363

This PR:

  • Adds synthetic function generation with Miden ABI transformation for all known transformation strategies for Miden stdlib and tx_kernel;
  • Partially restores the get_inputs and blake3 tests (up to HIR2 generation);
  • Adds get_id test for testing the HIR2 generation to test the no_transform strategy;

NOTE: I think that imported functions (the ones called from the synthetic ones) should probably be defined in the separate Component but since it requires establishing the World op it deserves a separate PR. I temporarily put them in the separate module in the same component.

EDIT: I'm not entirely happy with the code and overall design, but I decided to leave it as is and to get back to it after the Component Model translation is implemented, since it should affect the synthetic function generation significantly.

@greenhat greenhat force-pushed the greenhat/i363-miden-abi-transform branch from 0909bd5 to bca42be Compare February 21, 2025 08:07
@greenhat greenhat marked this pull request as draft February 21, 2025 14:23
@greenhat greenhat force-pushed the greenhat/i363-miden-abi-transform branch from bca42be to 552ff3c Compare February 21, 2025 14:38
@greenhat greenhat force-pushed the greenhat/i363-miden-abi-transform branch from 552ff3c to 11d6689 Compare February 21, 2025 14:56
@greenhat greenhat marked this pull request as ready for review February 21, 2025 15:16
@greenhat greenhat requested a review from bitwalker February 21, 2025 15:16
@greenhat greenhat changed the title feature(frontend): generate synthetic functions with Miden ABI transformation (stdlib, tx_kernel); [1/x] feature(frontend): generate synthetic functions with Miden ABI transformation (stdlib, tx_kernel); Feb 24, 2025
@bitwalker bitwalker merged commit b328b09 into next Feb 24, 2025
6 checks passed
@bitwalker bitwalker deleted the greenhat/i363-miden-abi-transform branch February 24, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants