feat: add is-prime example #420
Conversation
| ```bash | ||
| midenc run target/miden/release/is_prime.masp --inputs inputs.toml | ||
| ``` |
There was a problem hiding this comment.
This is just executes the program (rather than execute & prove), right?
There was a problem hiding this comment.
Yes, midenc run only executes the program and does not generate a proof. Since comparing our performance to other VMs would be a frequent case, should we add a command to midenc to execute and generate a proof?
There was a problem hiding this comment.
We could do this, but I wonder if it may be better to just add support for working with .masp files in miden-vm. It should be simple enough and wouldn't require re-implementing a bunch of other functionality here (e.g., analyze, debug, etc. commands).
There was a problem hiding this comment.
Yeah, my preference would be to support Miden packages in the VM proper, the need for midenc run is basically one of temporary necessity.
partylikeits1983
force-pushed
the
primality
branch
from
f8054f6 to
edd7c9a
Compare
bitwalker
dismissed
greenhat’s stale review
The requested change has been resolved
Adding a basic example of computing wether or not an integer is prime or not. I tested the function with values from this website: https://www.math.utah.edu/~pa/MDS/primes.html
For comparison, I tried running SP1's example for proving if the number$$29$$ is prime or not.
topsaid my CPU usage was 1000%. After a few minutes of the program running and the fans turning on my MBP M2, I decided to kill the program.Using the Miden compiler, proving that the number$$2147482583$$ is prime is near instant on the same computer.