Implement serialization/deserialization for Operation
#1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
reviewed
Jul 10, 2024
Fumuran
approved these changes
Jul 10, 2024
core/src/lib.rs
Outdated
Comment on lines
103
to
104
| pub use operations::opcode_constants::*; | ||
| pub use operations::{ |
There was a problem hiding this comment.
Probably we can join these two imports?
core/src/mast/node/call_node.rs
Outdated
| @@ -3,7 +3,8 @@ use core::fmt; | |||
| use miden_crypto::{hash::rpo::RpoDigest, Felt}; | |||
| use miden_formatting::prettier::PrettyPrint; | |||
|
|
|||
| use crate::{chiplets::hasher, Operation}; | |||
| use crate::chiplets::hasher; | |||
| use crate::{OPCODE_CALL, OPCODE_SYSCALL}; | |||
|
|
|||
There was a problem hiding this comment.
I noticed that in most of the node files you left this empty line between opcodes import and mast import. Was it intentional?
There was a problem hiding this comment.
No, actually I was assuming/hoping rustfmt was aggressive enough to always give the same kind of formatting.
Fixed in all node files.
plafer
force-pushed
the
plafer-fix-operation-deserialize
branch
from
fd38ded to
634b1b6
Compare
plafer
changed the title
Operation deserializationOperation
|
Rebased onto |
bobbinth
approved these changes
Jul 11, 2024
| @@ -101,8 +101,8 @@ pub mod prettier { | |||
|
|
|||
| mod operations; | |||
| pub use operations::{ | |||
| AdviceInjector, AssemblyOp, DebugOptions, Decorator, DecoratorIterator, DecoratorList, | |||
| Operation, SignatureKind, | |||
| opcode_constants::*, AdviceInjector, AssemblyOp, DebugOptions, Decorator, DecoratorIterator, | |||
There was a problem hiding this comment.
I'm a bit hesitant to export this many constants at the root level. Maybe we should export this as:
pub mod opcodes {
pub use super::operations::opcode_constants::*;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1370 (comment)