Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(processor): allow public construction of execution trace #1397

Merged
merged 1 commit into from
Jul 15, 2024
Merged

feat(processor): allow public construction of execution trace #1397

merged 1 commit into from
Jul 15, 2024

Conversation

bitwalker
Copy link
Contributor

Missed this when making Process public, but it is necessary to be able to construct an ExecutionTrace when you manually construct/execute a Process.

@bitwalker bitwalker added enhancement New feature or request processor Related to Miden VM processor labels Jul 15, 2024
@bitwalker bitwalker requested review from Fumuran and bobbinth July 15, 2024 21:20
@bitwalker bitwalker self-assigned this Jul 15, 2024
bobbinth
bobbinth approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bitwalker bitwalker merged commit b9fa825 into next Jul 15, 2024
15 checks passed
@bitwalker bitwalker deleted the bitwalker/pub-execution-trace-new branch July 15, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

@Fumuran Fumuran Awaiting requested review from Fumuran

Assignees

@bitwalker bitwalker

Labels
enhancement New feature or request processor Related to Miden VM processor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitwalker @bobbinth