Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(memory): allow more than 1 memory reads in the same clock cycle (same context & word address) #1626

Merged
merged 2 commits into from
Jan 27, 2025
Merged

feat(memory): allow more than 1 memory reads in the same clock cycle (same context & word address) #1626

merged 2 commits into from
Jan 27, 2025

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Jan 16, 2025 •
edited
Loading

Closes: #1622

@plafer plafer force-pushed the plafer-multiple-memory-accesses-same-clk branch from 039d97e to 11a6e51 Compare January 17, 2025 14:24
@plafer plafer requested a review from bobbinth January 17, 2025 14:25
@plafer plafer marked this pull request as ready for review January 17, 2025 14:25
@plafer plafer requested a review from Al-Kindi-0 January 17, 2025 14:25
Base automatically changed from element-addressable-memory to next January 22, 2025 09:21
bobbinth
bobbinth approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left some small comments/questions inline.

@Al-Kindi-0 - could you take a look as well?

Al-Kindi-0
Al-Kindi-0 approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@Al-Kindi-0 Al-Kindi-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

@plafer plafer merged commit 3c8013d into next Jan 27, 2025
9 checks passed
@plafer plafer deleted the plafer-multiple-memory-accesses-same-clk branch January 27, 2025 16:42
@bobbinth bobbinth mentioned this pull request Jan 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

@Al-Kindi-0 Al-Kindi-0 Al-Kindi-0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plafer @bobbinth @Al-Kindi-0