Fix chiplets bus #1664
Merged
Fix chiplets bus #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plafer
force-pushed
the
plafer-1545-fix-chiplets-bus
branch
from
4612598 to
b60b521
Compare
Al-Kindi-0
approved these changes
Feb 17, 2025
processor/src/debug.rs
Outdated
| fn source(&self) -> &str; | ||
| } | ||
|
|
||
| /// Note: we use `Vec` internall instead of a `BTreeMap` as a workaround for field elements not |
bobbinth
reviewed
Feb 19, 2025
There was a problem hiding this comment.
Looks good! Thank you! This is a great addition and I really like the concept of bus messages. I left a few comments inline with potential improvement suggestions.
Also, just to double check: does this have any noticeable impact on the performance of the auxiliary trace building step?
bobbinth
reviewed
Feb 19, 2025
plafer
force-pushed
the
plafer-1545-fix-chiplets-bus
branch
from
24a7e65 to
9fda218
Compare
bobbinth
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1545
Our bus is quite hard to debug due to the lack of insight into which request/response were not matched when things go wrong. This PR
miden-basenode_indexin themrupdateandmpverifytests. There were some tests failing inmiden-basedue to that, but I think it was a bug I introduced in the refactoring (which wasn't caught by our tests).Some tests in
miden-basestill fail, but only due to a problem with rcombbase. Since it is going away with #1661, I didn't spend time debugging/fixing it - we should do that with #1661 (if there is still a problem).Fun fact: with the new
BusDebugger, identifying the problems with the bus was very quick 😄