Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty trie #6

Merged
merged 11 commits into from
Jan 29, 2024
Merged

Empty trie #6

merged 11 commits into from
Jan 29, 2024

Conversation

praetoriansentry
Copy link
Contributor

@praetoriansentry praetoriansentry commented Jan 29, 2024 •
edited
Loading

Adding the witness fixes from @wborgeaud and minor documentation notes.

Nashtare
Nashtare approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple nits just to make peace with my OCD, but LGTM :)
Probably not worth adding a TODO to halve the number of RPCs for block_hashes fetching, that's not really a bottleneck anymore compared to the state trie.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
praetoriansentry and others added 3 commits January 29, 2024 16:20
@praetoriansentry @Nashtare
Update README.md
c7f0e6e 
Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>
@praetoriansentry @Nashtare
Update README.md
8758104 
Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>
@praetoriansentry @Nashtare
Update README.md
36fa97c 
Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>
@praetoriansentry praetoriansentry merged commit 3af5950 into main Jan 29, 2024
3 checks passed
@praetoriansentry praetoriansentry deleted the empty_trie branch January 29, 2024 21:23
wborgeaud
wborgeaud approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@wborgeaud wborgeaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborgeaud wborgeaud wborgeaud approved these changes

@Nashtare Nashtare Nashtare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@praetoriansentry @wborgeaud @Nashtare