feat: Implement Columns view for BytePackingStark
#422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: evm_arithmetization
|
@einar-polygon what's the status on the review? Do you need help? |
einar-polygon
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Most changes are mechanical rewrites from constants to stuct fields and seem correct to me.
The combination of macros and unsafe code does not seem boring. It is difficult for me to identify buggy edge-cases in this type of code.
Overall it seems like these changes use the same mechanisms that are used in the other starks and by virtue of that, it is exactly what it is expected to be.
lgtm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the work in #312