Added derives to pub types where possible for mpt_trie
#456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BGluth
commented
Jul 30, 2024
BGluth
commented
- I think for public libraries it's generally a good idea to add as many derives as possible to public types since we want to make these types as easy to use as possible for the user.
- This PR just goes through and adds derives where possible (for all of the cases where we don't need to add any manual trait impls).
- I think for public libraries it's generally a good idea to add as many derives as possible to public types since we want to make these types as easy to use as possible for the user. - This PR just goes through and adds derives where possible (for all of the cases where we don't need to add any manual trait impls).
github-actions
bot
added
the
crate: mpt_trie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.