Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2-to-1 test for Cancun #464

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Fix 2-to-1 test for Cancun #464

merged 1 commit into from
Aug 7, 2024

Conversation

Nashtare
Copy link
Collaborator

@Nashtare Nashtare commented Aug 5, 2024

The test is being ignored and hence wasn't updated during the Cancun upgrade.

Also cleaning it up, as we were actually processing dummy payloads unlike what the initial code mentioned.

@Nashtare Nashtare added this to the x Misc. milestone Aug 5, 2024
@Nashtare Nashtare self-assigned this Aug 5, 2024
@Nashtare Nashtare requested a review from muursh as a code owner August 5, 2024 19:25
@github-actions github-actions bot added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Aug 5, 2024
Copy link
Contributor

@muursh muursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues from me

@Nashtare Nashtare merged commit fb636ad into develop Aug 7, 2024
14 of 15 checks passed
@Nashtare Nashtare deleted the fix-2-to-1 branch August 7, 2024 15:32
Copy link
Contributor

@einar-polygon einar-polygon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like safe changes to dummy GenerationInputs.

@Nashtare
Copy link
Collaborator Author

Nashtare commented Aug 9, 2024

There's no change to dummy inputs, the previous version was already ignoring the txn. The only real fix is the beacon roots update for Cancun's related EIP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants