Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(zero-bin): verifier binary not picking up pre-processed circuits #474

Merged
merged 2 commits into from
Aug 8, 2024
Merged

bug(zero-bin): verifier binary not picking up pre-processed circuits #474

merged 2 commits into from
Aug 8, 2024

Conversation

temaniarpit27
Copy link
Contributor

@github-actions github-actions bot added the crate: zero_bin Anything related to the zero-bin subcrates. label Aug 7, 2024
Nashtare
Nashtare reviewed Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's exactly the same code as on the leader / worker side right? Maybe worth defining the const and grouping the update mechanism in a function in common/ instead.

@temaniarpit27
Copy link
Contributor Author

temaniarpit27 commented Aug 7, 2024 •
edited
Loading

It's exactly the same code as on the leader / worker side right? Maybe worth defining the const and grouping the update mechanism in a function in common/ instead.

One more alternative is to use env!("EVM_ARITHMETIZATION_PKG_VER") instead of https://github.com/0xPolygonZero/zk_evm/blob/develop/zero_bin/common/src/prover_state/persistence.rs#L112
This will work as we are now using build scripts to set this var now.
What do you suggest?

@Nashtare Nashtare merged commit 3f20a79 into develop Aug 8, 2024
15 checks passed
@Nashtare Nashtare deleted the arpit/465 branch August 8, 2024 13:23
@Nashtare Nashtare added this to the Testing and Validation milestone Sep 4, 2024
@temaniarpit27 temaniarpit27 self-assigned this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nashtare Nashtare Nashtare approved these changes

@muursh muursh Awaiting requested review from muursh muursh is a code owner

Assignees

@temaniarpit27 temaniarpit27

Labels
crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Zero EVM
Status: Done
Milestone
Testing and Validation
Development

Successfully merging this pull request may close these issues.
2 participants
@temaniarpit27 @Nashtare