Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove duplicate new_txn_trie_node_byte #477

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

Nashtare
Copy link
Collaborator

@Nashtare Nashtare commented Aug 8, 2024

Companion of 0xPolygonZero/erigon#17.
closes #248

We were already ignoring it during processing, but still parsing it. It's clearer to remove it fully, and saves some bandwidth when fetching witnesses.

@Nashtare Nashtare self-assigned this Aug 8, 2024
@Nashtare Nashtare requested a review from muursh as a code owner August 8, 2024 14:01
@github-actions github-actions bot added crate: trace_decoder Anything related to the trace_decoder crate. crate: zero_bin Anything related to the zero-bin subcrates. labels Aug 8, 2024
@Nashtare Nashtare added this to the x Misc. milestone Aug 9, 2024
@Nashtare Nashtare merged commit a53a34c into develop Aug 15, 2024
15 checks passed
@Nashtare Nashtare deleted the remove_duplicate_txn_bytestring branch August 15, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: trace_decoder Anything related to the trace_decoder crate. crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Purge new_txn_trie_node_byte in TxnMeta from trace protocol
3 participants