Fix account creation reversion in decoder processing #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: trace_decoder
github-actions
bot
added
the
crate: evm_arithmetization
atanmarko
pushed a commit
that referenced
this pull request
Aug 14, 2024
* Fix account creation reversion in decoder processing * Also prune storage if account is removed * Handle all reverts cases together * Pacify mighty clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to force inclusion of non-yet existing accounts in our block witness payloads so that the prover can access their position when creating them.
However, the decoder isn't currently checking whether the dummy account we're inserting still exists after txn execution, which may not be the case if the txn reverted.
This adds the check, and also adds a payload from a dev chain that was previously failing without this fix.