Fix SELFDESTRUCT
#487
Merged
Fix SELFDESTRUCT
#487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate: trace_decoder
|
Hmm actually this test block has some remaining issues for the consistency check with header root, probably due to the known regressions around |
github-actions
bot
removed
the
crate: trace_decoder
muursh
approved these changes
Aug 12, 2024
hratoanina
approved these changes
Aug 12, 2024
Nashtare
added a commit
that referenced
this pull request
Aug 14, 2024
atanmarko
pushed a commit
that referenced
this pull request
Aug 14, 2024
atanmarko
pushed a commit
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were appending to the "newly create contract lists" any target of a
CREATEorCREATE2, but the latter may be targeting existing accounts (especially accounts already having funds). This changes the behavior of EIP-6780, as it shouldn't wipe out the entire account but only remove the contract bytecode and drain funds, if a contract is being deployed and SELFDESTRUCT is called within the same transaction.Added a test case that highlights this behavior: