Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Apply Material 3 theme #65

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

stefan-niedermann
Copy link
Contributor

  • Based on colors statically generated by nextcloud-common library (no new dependency has been introduced).
  • Some layouts have been simplified and specific text styles have been replaced by generalized style.
  • Workarounds for the preferences library not full supporting Material 3 yet have been added.

Refs: https://m3.material.io/

Light Dark
light dark

Based on colors generated by nextcloud-common library.
Some layouts have been simplified and specific text styles have been replaced by generalized style.
Workarounds for the preferences library not full supporting Material 3 yet have been added.

Refs:
https://m3.material.io/
https://github.com/nextcloud/android-common
@0xf104a 0xf104a self-requested a review October 23, 2023 17:44
@0xf104a 0xf104a added the enhancement New feature or request label Oct 23, 2023
@0xf104a 0xf104a added this to the 1.0-beta17 milestone Oct 23, 2023
Copy link
Owner

@0xf104a 0xf104a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello.
Thankyou very much for submitting merge request with your improvements to my app! I like your design and see no issues with code, so merging your changes straight away

@0xf104a 0xf104a merged commit 250b5ec into 0xf104a:main Oct 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants