Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement websocket in addition to polling #70

Merged
merged 17 commits into from
Dec 3, 2023
Merged

Implement websocket in addition to polling #70

merged 17 commits into from
Dec 3, 2023

Conversation

0xf104a
Copy link
Owner

@0xf104a 0xf104a commented Nov 19, 2023 •
edited
Loading

This pull request adds ability to use notify_push websocket instead of polling implementing #4 and likely partially resolving #67
The following tasks should be accomplished in order to get minimal support of websocket

  • Update interfaces and refactor in order to have two implementation of service
  • Update settings implementation
  • Implement creating websocket client and authorizing fot HTTP API
  • Implement service
    • Initially get notifications(as websocket won't send us old ones)
    • Monitor connections state changes(when we disconnect and reconnect we should use HTTP to get possibly skipped notifications and connect to WS again)
    • OPTIONALLY: refactor old service more in order to both services to have common base in handling notifications
  • Update UI
    • Add switch for using websocket
    • If switch for websocket is enabled, disable polling interval(and probably some other preferences)

@0xf104a 0xf104a added enhancement New feature or request WIP Pull request is not ready and is in progress of development labels Nov 19, 2023
@0xf104a 0xf104a self-assigned this Nov 19, 2023
@0xf104a 0xf104a marked this pull request as draft November 19, 2023 12:51
@0xf104a 0xf104a linked an issue Nov 19, 2023 that may be closed by this pull request
[feature request] Use notify_push #4
Closed
@0xf104a 0xf104a added the performance Performance of app is impacted label Nov 21, 2023
@0xf104a 0xf104a added this to the 1.1-beta18 milestone Nov 27, 2023
@0xf104a 0xf104a marked this pull request as ready for review December 3, 2023 16:08
@0xf104a 0xf104a merged commit 7c600e1 into main Dec 3, 2023
2 checks passed
@0xf104a 0xf104a changed the title WIP: Implement websocket in addition to polling Implement websocket in addition to polling Dec 3, 2023
@0xf104a 0xf104a deleted the 4-use-notify_push branch December 3, 2023 16:12
@0xf104a 0xf104a removed the WIP Pull request is not ready and is in progress of development label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0xf104a 0xf104a

Labels
enhancement New feature or request performance Performance of app is impacted
Projects
None yet
Milestone
1.1-beta18
Development

Successfully merging this pull request may close these issues.

[feature request] Use notify_push
1 participant
@0xf104a