Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: return tx response in approveRoute handler #353

Merged
merged 1 commit into from
Jan 7, 2025
Merged

feat: return tx response in approveRoute handler #353

merged 1 commit into from
Jan 7, 2025

Conversation

genaroibc
Copy link
Contributor

  • return transaction response in approveRoute handler

@odcey
Copy link
Contributor

odcey commented Jan 7, 2025

For context, this Pull request is to allow more flexibility on frontends, so that they can handle an UI action (like loading or timeout) before the .wait() call

jmdev3
jmdev3 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@jmdev3 jmdev3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@odcey odcey merged commit 579a1a0 into main-v2 Jan 7, 2025
5 checks passed
@odcey odcey deleted the feat/return-approve-tx-in-handler branch January 7, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdev3 jmdev3 jmdev3 approved these changes

@odcey odcey odcey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@genaroibc @odcey @jmdev3