Apply suggestions from code review

Co-authored-by: François de Metz <francois@2metz.fr>
1024pix · Aug 2, 2023 · b80f942 · b80f942
1 parent 093f63c
commit b80f942
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/metabase/table_metabase_permission.go b/metabase/table_metabase_permission.go
@@ -29,8 +29,8 @@ func tableMetabasePermission() *plugin.Table {
 		},
 		Columns: []*plugin.Column{
 			// Key column cannot be a pointer. Transform helps us to manage them
-			{Name: "group_id", Type: proto.ColumnType_INT, Transform: transform.FromField("GroupId"), Description: "ID of group."},
-			{Name: "db_id", Type: proto.ColumnType_INT, Transform: transform.FromField("DbId"), Description: "ID of database"},
+			{Name: "group_id", Type: proto.ColumnType_INT, Transform: transform.FromField("GroupId"), Description: "ID of the group."},
+			{Name: "db_id", Type: proto.ColumnType_INT, Transform: transform.FromField("DbId"), Description: "ID of the database."},
 			{Name: "download_native", Type: proto.ColumnType_STRING, Transform: transform.FromField("DownloadNative"), Description: "Type of download."},
 			{Name: "download_schema", Type: proto.ColumnType_STRING, Transform: transform.FromField("DownloadSchema"), Description: "Schema that you can download."},
 			{Name: "data_native", Type: proto.ColumnType_STRING, Transform: transform.FromField("DataNative"), Description: "Type of data."},

diff --git a/metabase/table_metabase_permission_data.go b/metabase/table_metabase_permission_data.go
@@ -20,8 +20,8 @@ const (
 
 var SubPermissionColum = []*plugin.Column{
 	// Key column cannot be a pointer. Transform helps us to manage them
-	{Name: "group_id", Type: proto.ColumnType_INT, Transform: transform.FromField("GroupId"), Description: "ID of group."},
-	{Name: "db_id", Type: proto.ColumnType_INT, Transform: transform.FromField("DbId"), Description: "ID of database"},
+	{Name: "group_id", Type: proto.ColumnType_INT, Transform: transform.FromField("GroupId"), Description: "ID of the group."},
+	{Name: "db_id", Type: proto.ColumnType_INT, Transform: transform.FromField("DbId"), Description: "ID of the database."},
 	{Name: "schema_name", Type: proto.ColumnType_STRING, Transform: transform.FromField("SchemaName"), Description: "Name of schema."},
 	{Name: "table_id", Type: proto.ColumnType_INT, Transform: transform.FromField("TableId"), Description: "Table id."},
 	{Name: "level_access", Type: proto.ColumnType_STRING, Transform: transform.FromField("LevelAccess"), Description: "Level access of table."},