Skip to content

Commit

Permalink
Merge pull request #113 from 10up/release/1.3.1
Browse files Browse the repository at this point in the history
Release/1.3.1
  • Loading branch information
dkotter authored Oct 19, 2023
2 parents 6e52878 + 426d985 commit febe7de
Show file tree
Hide file tree
Showing 7 changed files with 48 additions and 21 deletions.
2 changes: 2 additions & 0 deletions .distignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@
/.wordpress-org
/node_modules
/src
/tests
/vendor

# Files
.*
CHANGELOG.md
CODE_OF_CONDUCT.md
composer.json
composer.lock
CONTRIBUTING.md
CREDITS.md
LICENSE.md
Expand Down
31 changes: 23 additions & 8 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,34 @@ All notable changes to this project will be documented in this file, per [the Ke

## [Unreleased] - TBD

## [1.3.0] - TBD
## [1.3.1] - 2023-10-19
### Added
- Check for minimum required PHP version before loading the plugin (props [@kmgalanakis](https://github.com/kmgalanakis), [@Sidsector9](https://github.com/Sidsector9) via [#103](https://github.com/10up/retro-winamp-block/pull/103)).

### Changed
- Update our dependency review GitHub Action (props [@jeffpaul](https://github.com/jeffpaul), [@Sidsector9](https://github.com/Sidsector9) via [#97](https://github.com/10up/retro-winamp-block/pull/97)).
- Bump WordPress "tested up to" version 6.3 (props [@kmgalanakis](https://github.com/kmgalanakis), [@iamdharmesh](https://github.com/iamdharmesh), [@jeffpaul](https://github.com/jeffpaul), [@peterwilsoncc](https://github.com/peterwilsoncc) via [#102](https://github.com/10up/retro-winamp-block/pull/102), [#105](https://github.com/10up/retro-winamp-block/pull/105)).

### Security
- Bump `semver` from 5.7.1 to 5.7.2 (props [@dependabot](https://github.com/apps/dependabot), [@ravinderk](https://github.com/ravinderk) via [#98](https://github.com/10up/retro-winamp-block/pull/98)).
- Bump `word-wrap` from 1.2.3 to 1.2.5 (props [@dependabot](https://github.com/apps/dependabot), [@peterwilsoncc](https://github.com/peterwilsoncc) via [#106](https://github.com/10up/retro-winamp-block/pull/106)).
- Bump `tough-cookie` from 4.1.2 to 4.1.3 and `@cypress/request` from 2.88.11 to 3.0.1 (props [@dependabot](https://github.com/apps/dependabot), [@Sidsector9](https://github.com/Sidsector9) via [#107](https://github.com/10up/retro-winamp-block/pull/107), [#108](https://github.com/10up/retro-winamp-block/pull/108)).
- Bump `cypress` from 10.11.0 to 13.1.0 (props [@dependabot](https://github.com/apps/dependabot), [@Sidsector9](https://github.com/Sidsector9) via [#108](https://github.com/10up/retro-winamp-block/pull/108)).
- Bump `postcss` from 8.4.20 to 8.4.31 (props [@dependabot](https://github.com/apps/dependabot), [@faisal-alvi](https://github.com/faisal-alvi) via [#110](https://github.com/10up/retro-winamp-block/pull/110)).

## [1.3.0] - 2023-04-18
### Added
- E2E tests using Cypress (props [@vikrampm1](https://github.com/vikrampm1), [@barneyjeffries](https://github.com/barneyjeffries), [@iamdharmesh](https://github.com/iamdharmesh), [@cadic](https://github.com/cadic)) via [#87](https://github.com/10up/retro-winamp-block/pull/87).
- E2E tests using Cypress (props [@vikrampm1](https://github.com/vikrampm1), [@barneyjeffries](https://github.com/barneyjeffries), [@iamdharmesh](https://github.com/iamdharmesh), [@cadic](https://github.com/cadic) via [#87](https://github.com/10up/retro-winamp-block/pull/87)).

### Changed
- Bump WordPress "tested up to" version from 6.1 to 6.2 (props [@jayedul](https://github.com/jayedul), [@peterwilsoncc](https://github.com/peterwilsoncc)) via [#92](https://github.com/10up/retro-winamp-block/pull/92)
- [Support Level](https://github.com/10up/retro-winamp-block#support-level) from `Active` to `Stable` (props [@jeffpaul](https://github.com/jeffpaul), [@Sidsector9](https://github.com/Sidsector9)) via [#94](https://github.com/10up/retro-winamp-block/pull/94).
- Bump WordPress "tested up to" version from 6.1 to 6.2 (props [@jayedul](https://github.com/jayedul), [@peterwilsoncc](https://github.com/peterwilsoncc) via [#92](https://github.com/10up/retro-winamp-block/pull/92)).
- [Support Level](https://github.com/10up/retro-winamp-block#support-level) from `Active` to `Stable` (props [@jeffpaul](https://github.com/jeffpaul), [@Sidsector9](https://github.com/Sidsector9) via [#94](https://github.com/10up/retro-winamp-block/pull/94)).

### Security
- Bump `simple-git` from `3.15.1` to `3.16.0` (props [@Sidsector9](https://github.com/Sidsector9)) via [#82](https://github.com/10up/retro-winamp-block/pull/82).
- Bump `http-cache-semantics` from `4.1.0` to `4.1.1` (props [@peterwilsoncc](https://github.com/peterwilsoncc)) via [#85](https://github.com/10up/retro-winamp-block/pull/85).
- Bump `@sideway/formula` from `3.0.0` to `3.0.1` (props [@faisal-alvi](https://github.com/faisal-alvi)) via [#86](https://github.com/10up/retro-winamp-block/pull/86).
- Bump `webpack` from `5.73.0` to `5.76.2` (props [@faisal-alvi](https://github.com/faisal-alvi)) via [#90](https://github.com/10up/retro-winamp-block/pull/90).
- Bump `simple-git` from `3.15.1` to `3.16.0` (props [@Sidsector9](https://github.com/Sidsector9) via [#82](https://github.com/10up/retro-winamp-block/pull/82)).
- Bump `http-cache-semantics` from `4.1.0` to `4.1.1` (props [@peterwilsoncc](https://github.com/peterwilsoncc) via [#85](https://github.com/10up/retro-winamp-block/pull/85)).
- Bump `@sideway/formula` from `3.0.0` to `3.0.1` (props [@faisal-alvi](https://github.com/faisal-alvi) via [#86](https://github.com/10up/retro-winamp-block/pull/86)).
- Bump `webpack` from `5.73.0` to `5.76.2` (props [@faisal-alvi](https://github.com/faisal-alvi) via [#90](https://github.com/10up/retro-winamp-block/pull/90)).

## [1.2.0] - 2023-01-30
**Note that this release changes the minimum PHP version to from 5.6 to 7.4.**
Expand Down Expand Up @@ -80,6 +94,7 @@ All notable changes to this project will be documented in this file, per [the Ke
- Initial release of the Winamp Block plugin. 🎉

[Unreleased]: https://github.com/10up/retro-winamp-block/compare/trunk...develop
[1.3.1]: https://github.com/10up/retro-winamp-block/compare/1.3.0...1.3.1
[1.3.0]: https://github.com/10up/retro-winamp-block/compare/1.2.0...1.3.0
[1.2.0]: https://github.com/10up/retro-winamp-block/compare/1.1.0...1.2.0
[1.1.0]: https://github.com/10up/retro-winamp-block/compare/1.0.1...1.1.0
Expand Down
2 changes: 1 addition & 1 deletion CREDITS.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ The following individuals are responsible for curating the list of issues, respo

Thank you to all the people who have already contributed to this repository via bug reports, code, design, ideas, project management, translation, testing, etc.

[Jeffrey Paul (@jeffpaul)](https://github.com/jeffpaul), [Tung Du (@dinhtungdu)](https://github.com/dinhtungdu), [Fabian Kägy (@fabiankaegy)](https://github.com/fabiankaegy), [Darin Kotter (@dkotter)](https://github.com/dkotter), [Mel Choyce-Dwan (@melchoyce)](https://github.com/melchoyce), [Crisoforo Gaspar Hernández (@mitogh)](https://github.com/mitogh), [Helen Hou-Sandi (@helen)](https://github.com/helen), [Sudip Dadhaniya (@sudip-10up)](https://github.com/sudip-10up), [Dharmesh Patel (@iamdharmesh)](https://github.com/iamdharmesh), [Peter Wilson (@peterwilsoncc)](https://github.com/peterwilsoncc), [Faisal Alvi (@faisal-alvi)](https://github.com/faisal-alvi), [Siddharth Thevaril (@Sidsector9)](https://github.com/Sidsector9), [Vikram Moparthy (@vikrampm1)](https://github.com/vikrampm1), [Peter Wilson (@peterwilsoncc)](https://github.com/peterwilsoncc), [Quamruz Zaman (@zamanq)](https://github.com/zamanq), [Ian Svoboda (@iansvo)](https://github.com/iansvo), [Ajay Maurya (@ajmaurya99)](https://github.com/ajmaurya99), [Max Lyuchin (@cadic)](https://github.com/cadic), [Jayedul Kabir (@jayedul)](https://github.com/jayedul), [Barney Jeffries (@barneyjeffries)](https://github.com/barneyjeffries).
[Jeffrey Paul (@jeffpaul)](https://github.com/jeffpaul), [Tung Du (@dinhtungdu)](https://github.com/dinhtungdu), [Fabian Kägy (@fabiankaegy)](https://github.com/fabiankaegy), [Darin Kotter (@dkotter)](https://github.com/dkotter), [Mel Choyce-Dwan (@melchoyce)](https://github.com/melchoyce), [Crisoforo Gaspar Hernández (@mitogh)](https://github.com/mitogh), [Helen Hou-Sandi (@helen)](https://github.com/helen), [Sudip Dadhaniya (@sudip-10up)](https://github.com/sudip-10up), [Dharmesh Patel (@iamdharmesh)](https://github.com/iamdharmesh), [Peter Wilson (@peterwilsoncc)](https://github.com/peterwilsoncc), [Faisal Alvi (@faisal-alvi)](https://github.com/faisal-alvi), [Siddharth Thevaril (@Sidsector9)](https://github.com/Sidsector9), [Vikram Moparthy (@vikrampm1)](https://github.com/vikrampm1), [Peter Wilson (@peterwilsoncc)](https://github.com/peterwilsoncc), [Quamruz Zaman (@zamanq)](https://github.com/zamanq), [Ian Svoboda (@iansvo)](https://github.com/iansvo), [Ajay Maurya (@ajmaurya99)](https://github.com/ajmaurya99), [Max Lyuchin (@cadic)](https://github.com/cadic), [Jayedul Kabir (@jayedul)](https://github.com/jayedul), [Barney Jeffries (@barneyjeffries)](https://github.com/barneyjeffries), [Konstantinos Galanakis (@kmgalanakis)](https://github.com/kmgalanakis), [Ravinder Kumar (@ravinderk)](https://github.com/ravinderk), [GitHub Dependabot (@dependabot)](https://github.com/apps/dependabot).

## Libraries

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "winamp-block",
"version": "1.3.0",
"version": "1.3.1",
"description": "A Winamp-styled audio block for all your retro music player needs.",
"author": {
"name": "10up",
Expand Down
14 changes: 12 additions & 2 deletions readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Contributors: 10up, dinhtungdu, fabiankaegy, dkotter, melchoyce, jeffpaul
Tags: winamp, webamp, mp3, music, audio, player, playlist, equalizer, block
Requires at least: 6.1
Tested up to: 6.3
Stable tag: 1.3.0
Stable tag: 1.3.1
Requires PHP: 7.4
License: GPLv2 or later
License URI: https://www.gnu.org/licenses/gpl-2.0.html
Expand Down Expand Up @@ -45,7 +45,17 @@ Details on how to create a new skin is available [here](https://github.com/WACUP

== Changelog ==

= 1.3.0 - TBD =
= 1.3.1 - 2023-10-19 =
* **Added:** Check for minimum required PHP version before loading the plugin (props [@kmgalanakis](https://github.com/kmgalanakis), [@Sidsector9](https://github.com/Sidsector9) via [#103](https://github.com/10up/retro-winamp-block/pull/103)).
* **Changed:** Update our dependency review GitHub Action (props [@jeffpaul](https://github.com/jeffpaul), [@Sidsector9](https://github.com/Sidsector9) via [#97](https://github.com/10up/retro-winamp-block/pull/97)).
* **Changed:** Bump WordPress "tested up to" version 6.3 (props [@kmgalanakis](https://github.com/kmgalanakis), [@iamdharmesh](https://github.com/iamdharmesh), [@jeffpaul](https://github.com/jeffpaul), [@peterwilsoncc](https://github.com/peterwilsoncc) via [#102](https://github.com/10up/retro-winamp-block/pull/102), [#105](https://github.com/10up/retro-winamp-block/pull/105)).
* **Security:** Bump `semver` from 5.7.1 to 5.7.2 (props [@dependabot](https://github.com/apps/dependabot), [@ravinderk](https://github.com/ravinderk) via [#98](https://github.com/10up/retro-winamp-block/pull/98)).
* **Security:** Bump `word-wrap` from 1.2.3 to 1.2.5 (props [@dependabot](https://github.com/apps/dependabot), [@peterwilsoncc](https://github.com/peterwilsoncc) via [#106](https://github.com/10up/retro-winamp-block/pull/106)).
* **Security:** Bump `tough-cookie` from 4.1.2 to 4.1.3 and `@cypress/request` from 2.88.11 to 3.0.1 (props [@dependabot](https://github.com/apps/dependabot), [@Sidsector9](https://github.com/Sidsector9) via [#107](https://github.com/10up/retro-winamp-block/pull/107), [#108](https://github.com/10up/retro-winamp-block/pull/108)).
* **Security:** Bump `cypress` from 10.11.0 to 13.1.0 (props [@dependabot](https://github.com/apps/dependabot), [@Sidsector9](https://github.com/Sidsector9) via [#108](https://github.com/10up/retro-winamp-block/pull/108)).
* **Security:** Bump `postcss` from 8.4.20 to 8.4.31 (props [@dependabot](https://github.com/apps/dependabot), [@faisal-alvi](https://github.com/faisal-alvi) via [#110](https://github.com/10up/retro-winamp-block/pull/110)).

= 1.3.0 - 2023-04-18 =
* **Added:** E2E tests using Cypress (props [@vikrampm1](https://github.com/vikrampm1), [@barneyjeffries](https://github.com/barneyjeffries), [@iamdharmesh](https://github.com/iamdharmesh), [@cadic](https://github.com/cadic)) via [#87](https://github.com/10up/retro-winamp-block/pull/87).
* **Changed:** Bump WordPress "tested up to" version from 6.1 to 6.2 (props [@jayedul](https://github.com/jayedul), [@peterwilsoncc](https://github.com/peterwilsoncc)) via [#92](https://github.com/10up/retro-winamp-block/pull/92)
* **Changed:** [Support Level](https://github.com/10up/retro-winamp-block#support-level) from `Active` to `Stable` (props [@jeffpaul](https://github.com/jeffpaul), [@Sidsector9](https://github.com/Sidsector9)) via [#94](https://github.com/10up/retro-winamp-block/pull/94).
Expand Down
14 changes: 7 additions & 7 deletions retro-webamp-block.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Plugin Name: Retro Winamp Block
* Plugin URI: https://wordpress.org/plugins/retro-winamp-block/
* Description: A Winamp-styled audio block for all your retro music player needs.
* Version: 1.3.0
* Version: 1.3.1
* Requires at least: 6.1
* Requires PHP: 7.4
* Author: 10up
Expand All @@ -24,7 +24,7 @@
*
* @return string Minimum version required.
*/
function minimum_php_requirement(): string {
function minimum_php_requirement() {
return '7.4';
}

Expand All @@ -35,7 +35,7 @@ function minimum_php_requirement(): string {
*
* @return bool True if meets minimum requirements, false otherwise.
*/
function site_meets_php_requirements(): bool {
function site_meets_php_requirements() {
return version_compare( phpversion(), minimum_php_requirement(), '>=' );
}

Expand Down Expand Up @@ -110,8 +110,8 @@ function ( $block_content, $block, $instance ) {
if ( 'core/audio' !== $block['blockName'] ) {
return $block_content;
}
$attributes = $block['attrs'] ?? array();
$attachment_id = $attributes['id'] ?? 0;
$attributes = isset( $block['attrs'] ) ? $block['attrs'] : array();
$attachment_id = isset( $attributes['id'] ) ? $attributes['id'] : 0;
$attachment = get_post( $attachment_id );

// Stop here if $attachment can't be found.
Expand All @@ -120,8 +120,8 @@ function ( $block_content, $block, $instance ) {
}

$metadata = wp_get_attachment_metadata( $attachment_id );
$artist = $metadata['artist'] ?? '';
$title = $metadata['title'] ?? '';
$artist = isset( $metadata['artist'] ) ? $metadata['artist'] : '';
$title = isset( $metadata['title'] ) ? $metadata['title'] : '';
$new_props = array(
'artist' => $artist,
'title' => $title,
Expand Down

0 comments on commit febe7de

Please sign in to comment.