🐛 Fix Alchemy#download(path) breaking when no name is found to stor…

…e file as
11ways · Dec 27, 2024 · 8bea114 · 8bea114
1 parent 0dd6c5f
commit 8bea114
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 * Fix `Conduit#parseRequest()` forgetting GET query parameters when overriding respone url
 * Make `Model#aggregate(pipeline)` work again
+* Fix `Alchemy#download(path)` breaking when no name is found to store file as
 
 ## 1.4.0-alpha.8 (2024-11-28)
 

diff --git a/lib/core/alchemy_functions.js b/lib/core/alchemy_functions.js
@@ -1159,7 +1159,7 @@ function convertDataUriToFile(data_uri) {
  *
  * @author   Jelle De Loecker <jelle@elevenways.be>
  * @since    1.3.0
- * @version  1.3.0
+ * @version  1.4.0
  *
  * @param    {string}   url
  *
@@ -1226,10 +1226,14 @@ Alchemy.setMethod(function download(url, options) {
 			}
 
 			if (!name) {
-				name = alchemy.ObjectId();
+				name = alchemy.ObjectId() + '';
 			}
 		}
 
+		if (!name || typeof name != 'string') {
+			name = alchemy.ObjectId() + '';
+		}
+
 		if (name.indexOf('/') > -1) {
 			name = name.replaceAll('/', '-');
 		}

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
 	"name": "alchemymvc",
 	"description": "MVC framework for Node.js",
-	"version": "1.4.0-alpha.8",
+	"version": "1.4.0-alpha.9",
 	"author": "Jelle De Loecker <jelle@elevenways.be>",
 	"keywords": [
 		"alchemy",