🐛 Fix TaskService#initSchedules() attempting to recreate already ex…

…isting system schedules
11ways · Nov 4, 2023 · 98dc7c5 · 98dc7c5
1 parent 48b337b
commit 98dc7c5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,7 @@
 * Move `Model#beforeSave()` to after validation
 * Make the `Decimal` classes globally available
 * Allow passing a custom context to `PathEvaluator#getValue(context)`
+* Fix `TaskService#initSchedules()` attempting to recreate already existing system schedules
 
 ## 1.3.19 (2023-10-18)
 

diff --git a/lib/class/task_service.js b/lib/class/task_service.js
@@ -105,7 +105,7 @@ Service.setMethod(function checksumSystemSchedule(type_path, cron, settings) {
  *
  * @author   Jelle De Loecker   <jelle@elevenways.be>
  * @since    1.3.17
- * @version  1.3.17
+ * @version  1.3.20
  */
 Service.setMethod(async function initSchedules() {
 
@@ -179,6 +179,7 @@ Service.setMethod(async function initSchedules() {
 			// If this checksum has already been seen, also remove it
 			if (existing_system_records.has(checksum)) {
 				await record.remove();
+				continue;
 			}
 
 			// Update the record
@@ -188,6 +189,8 @@ Service.setMethod(async function initSchedules() {
 
 			await record.save();
 
+			existing_system_records.set(checksum, record);
+
 		} catch (err) {
 			alchemy.registerError(err);
 		}