🐛 Fix Conduit#parseRequest() forgetting GET query parameters when o…

…verriding respone url
11ways · Dec 27, 2024 · c672882 · c672882
1 parent d9c21bb
commit c672882
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 1.4.0-alpha.9 (WIP)
+
+* Fix `Conduit#parseRequest()` forgetting GET query parameters when overriding respone url
+
 ## 1.4.0-alpha.8 (2024-11-28)
 
 * Fix `_modelInstance` cache when keys are not strings

diff --git a/lib/class/conduit.js b/lib/class/conduit.js
@@ -511,7 +511,7 @@ Conduit.setMethod(function time() {
  *
  * @author   Jelle De Loecker <jelle@elevenways.be>
  * @since    0.2.0
- * @version  1.3.18
+ * @version  1.4.0
  *
  * @param    {IncomingMessage}   req
  * @param    {ServerResponse}    res
@@ -541,7 +541,7 @@ Conduit.setMethod(async function parseRequest() {
 	}
 
 	if (this.rewritten_request_route_param) {
-		let params = Object.assign({}, this.route_string_parameters, this.rewritten_request_route_param);
+		let params = Object.assign({...this.url.query}, this.route_string_parameters, this.rewritten_request_route_param);
 		let new_url = this.route.generateUrl(params, this);
 		this.overrideResponseUrl(new_url);
 	}