fix: startup html errors (#889)

--------- Co-authored-by: Robbert Ritsema <robbert@123inkt.nl> Co-authored-by: Frank Dekker <fdekker@123inkt.nl>
123inkt · Oct 18, 2024 · 7708140 · 7708140
1 parent 13e5eaa
commit 7708140
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 12 deletions.
diff --git a/docker-compose.override.yml b/docker-compose.override.yml
@@ -1,7 +1,4 @@
 ## overrides for development
-
-version: '3'
-
 services:
     nginx:
         volumes:

diff --git a/docker-compose.production.yml b/docker-compose.production.yml
@@ -1,7 +1,4 @@
 ## overrides for production
-
-version: '3'
-
 services:
     nginx:
         volumes:

diff --git a/docker-compose.yml b/docker-compose.yml
@@ -1,5 +1,3 @@
-version: '3'
-
 services:
     nginx:
         container_name: ${NGINX_CONTAINER:-nginx}

diff --git a/templates/app/admin/edit_repository.html.twig b/templates/app/admin/edit_repository.html.twig
@@ -56,7 +56,7 @@
     {{ inputFieldRow(form.repository.updateRevisionsInterval) }}
     {{ inputFieldRow(form.repository.validateRevisionsInterval) }}
 
-    {% if form.repository.gitlabProjectId %}
+    {% if form.repository.gitlabProjectId is defined %}
         <h4>{{ 'integrations'|trans }}</h4>
         <hr>
         {{ inputFieldRow(form.repository.gitlabProjectId) }}

diff --git a/templates/app/project/projects.html.twig b/templates/app/project/projects.html.twig
@@ -13,9 +13,11 @@
                            href="{{ path('DR\\Review\\Controller\\App\\Reviews\\ReviewsController', {id: repository.id}) }}">
                             {{- repository.displayName -}}
 
-                            <small class="d-block text-secondary">
-                                {{ projectsModel.revisionCount[repository.id]|format_number }} {{ 'revisions'|trans|lower }}
-                            </small>
+                            {% if projectsModel.revisionCount[repository.id] is defined %}
+                                <small class="d-block text-secondary">
+                                    {{ projectsModel.revisionCount[repository.id]|format_number }} {{ 'revisions'|trans|lower }}
+                                </small>
+                            {% endif %}
                         </a>
                     {%- endfor -%}
                 </div>