Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency twig/twig to v3.14.1 [SECURITY] #917

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 6, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
twig/twig (source) 3.14.0 -> 3.14.1 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-51754

Description

In a sandbox, an attacker can call __toString() on an object even if the __toString() method is not allowed by the security policy when the object is part of an array or an argument list (arguments to a function or a filter for instance).

Resolution

The sandbox mode now checks the __toString() method call on all objects.

The patch for this issue is available here for branch 3.x.

Credits

We would like to thank Jamie Schouten for reporting the issue and Fabien Potencier for providing the fix.

CVE-2024-51755

Description

In a sandbox, an attacker can access attributes of Array-like objects as they were not checked by the security policy.
They are now checked via the property policy and the __isset() method is now called after the security check.
This is a BC break.

Resolution

The sandbox mode now ensures access to array-like's properties is allowed.

The patch for this issue is available here for branch 3.11.x.

Credits

We would like to thank Jamie Schouten for reporting the issue and Nicolas Grekas for providing the fix.


Release Notes

twigphp/Twig (twig/twig)

v3.14.1

Compare Source

  • [BC BREAK] Fix a security issue in the sandbox mode allowing an attacker to call attributes on Array-like objects
    They are now checked via the property policy
  • Fix a security issue in the sandbox mode allowing an attacker to be able to call toString()
    under some circumstances on an object even if the __toString() method is not allowed by the security policy

Configuration

📅 Schedule: Branch creation - "" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the renovate label Nov 6, 2024
@renovate renovate bot force-pushed the renovate/packagist-twig-twig-vulnerability branch from 1be7dd9 to 52add93 Compare November 6, 2024 22:38
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (b3cfc78) to head (d658830).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #917   +/-   ##
=========================================
  Coverage     99.98%   99.98%           
  Complexity     3116     3116           
=========================================
  Files           533      533           
  Lines          9214     9214           
=========================================
  Hits           9213     9213           
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot force-pushed the renovate/packagist-twig-twig-vulnerability branch from 52add93 to 22e9a89 Compare November 8, 2024 22:47
@renovate renovate bot force-pushed the renovate/packagist-twig-twig-vulnerability branch from 22e9a89 to d658830 Compare November 9, 2024 20:11
@frankdekker frankdekker merged commit 1c8bcba into master Nov 9, 2024
3 checks passed
@frankdekker frankdekker deleted the renovate/packagist-twig-twig-vulnerability branch November 9, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant