Skip to content

Commit

Permalink
relocating fixed-clock entry, based on upstream advice
Browse files Browse the repository at this point in the history
See upstream -
raspberrypi/documentation#1671
raspberrypi/documentation#1673

Quoted here:

* Only Device Tree nodes at the top level of the tree and children of
  a bus node will be probed. For nodes added at run-time there is the
  further limitation that the bus must register for notifications of
  the addition and removal of children. However, there are exceptions
  that break this rule and cause confusion: the kernel explicitly
  scans the entire tree for some device types - clocks and interrupt
  controller being the two main ones - in order to (for clocks)
  initialise them early and/or (for interrupt controllers) in a
  particular order. This search mechanism only happens during booting
  and so doesn't work for nodes added by an overlay at run-time. It is
  therefore recommended for overlays to place fixed-clock nodes in the
  root of the tree unless it is guaranteed that the overlay will not
  be used at run-time.
  • Loading branch information
HinTak committed Sep 14, 2020
1 parent 955707d commit 47d97e7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion seeed-4mic-voicecard-overlay.dts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
};

fragment@1 {
target-path = "/clocks";
target-path = "/";
__overlay__ {
ac108_mclk: codec-mclk {
compatible = "fixed-clock";
Expand Down
2 changes: 1 addition & 1 deletion seeed-8mic-voicecard-overlay.dts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
};

fragment@1 {
target-path = "/clocks";
target-path = "/";
__overlay__ {
ac10x_mclk: codec-mclk {
compatible = "fixed-clock";
Expand Down

0 comments on commit 47d97e7

Please sign in to comment.