Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support envvar injection for Gradle tool window task #117

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

134130
Copy link
Owner

@134130 134130 commented Dec 26, 2024

Description

The gradle task can be ran on many routes.

This PR fixes the envvar cannot be loaded when Gradle Task is ran by Gradle Tool window.


Used a little hack: insert envvars to runConfiguration before execution, and add terminated litener to the execution, remove the envvars from it.

@134130 134130 self-assigned this Dec 26, 2024
@134130 134130 merged commit d682610 into main Dec 26, 2024
1 check passed
@134130 134130 deleted the cooper/gradle-task branch December 26, 2024 05:53
Copy link
Contributor

Qodana Community for JVM

25 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 17
Constructor parameter is never used as a property 🔶 Warning 1
Control flow with empty body 🔶 Warning 1
Unstable API Usage 🔶 Warning 1
Class member can have 'private' visibility ◽️ Notice 4
Nested lambda has shadowed implicit parameter ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2024.2.5
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mise env still do not auto-load when using Run/Debug Configurations
2 participants