Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to intellij-platform-gradle-plugin v2.0.0 #14

Merged
merged 6 commits into from
Aug 11, 2024
Merged

Conversation

134130
Copy link
Owner

@134130 134130 commented Aug 3, 2024

Description

@134130 134130 self-assigned this Aug 3, 2024
@134130
Copy link
Owner Author

134130 commented Aug 3, 2024

@joshuataylor Did I do it right?

@joshuataylor
Copy link

Last comment was for the wrong issue, I'll test and let you know.

@joshuataylor
Copy link

Use org.jetbrains.intellij.platform.module for the subprojects. This is a new feature so you don't need to do the gradle.taskGraph.whenReady( part.

It is basically a subplugin - see https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin.html#multi-module-project-structure

and

https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin.html#plugins

@joshuataylor
Copy link

Might be worth creating a CONTRIBUTING.md with tips about launching the IDEs (which honestly for me is usually when I forget something about a project :-))

I also wrote a bash script I quickly made which will add each supported IDE to .run in the same way the Run Plugin task is done.

Both my notes about contributing and runIde are here: https://gist.github.com/joshuataylor/8ed59c23f89756cf095ba3533fadc2aa

(will probably use both for other projects, it's super handy)

@134130
Copy link
Owner Author

134130 commented Aug 4, 2024

Use org.jetbrains.intellij.platform.module for the subprojects. This is a new feature so you don't need to do the gradle.taskGraph.whenReady( part.

It is basically a subplugin - see plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin.html#multi-module-project-structure

and

plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin.html#plugins

It looks so nice!!

@134130
Copy link
Owner Author

134130 commented Aug 4, 2024

Might be worth creating a CONTRIBUTING.md with tips about launching the IDEs (which honestly for me is usually when I forget something about a project :-))

I also wrote a bash script I quickly made which will add each supported IDE to .run in the same way the Run Plugin task is done.

Both my notes about contributing and runIde are here: gist.github.com/joshuataylor/8ed59c23f89756cf095ba3533fadc2aa

(will probably use both for other projects, it's super handy)

Thanks! For your information, intellij-gradle-plugin-platform v2 introduces intellijPlatformTesting, which makes no bash scripts for making test configuration.

@joshuataylor
Copy link

Thanks!! Was looking for that this morning through the docs, knew I saw it somewhere.

@134130 134130 merged commit b0e635b into main Aug 11, 2024
1 check failed
@134130 134130 deleted the migrate-2.0.0 branch August 11, 2024 02:00
134130 pushed a commit that referenced this pull request Aug 11, 2024
* Migrate to intellij-platform-gradle-plugin 2.0.0

* use `org.jetbrains.intellij.platform.modules` plugin

* Add CONTRIBUTING.md

* Update plugin until build to 242.*

* drop until build

* update changelog.md
134130 pushed a commit that referenced this pull request Aug 11, 2024
* Migrate to intellij-platform-gradle-plugin 2.0.0

* use `org.jetbrains.intellij.platform.modules` plugin

* Add CONTRIBUTING.md

* Update plugin until build to 242.*

* drop until build

* update changelog.md
134130 pushed a commit that referenced this pull request Aug 11, 2024
* Migrate to intellij-platform-gradle-plugin 2.0.0

* use `org.jetbrains.intellij.platform.modules` plugin

* Add CONTRIBUTING.md

* Update plugin until build to 242.*

* drop until build

* update changelog.md
134130 pushed a commit that referenced this pull request Aug 11, 2024
* Migrate to intellij-platform-gradle-plugin 2.0.0

* use `org.jetbrains.intellij.platform.modules` plugin

* Add CONTRIBUTING.md

* Update plugin until build to 242.*

* drop until build

* update changelog.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support intellij-platform-gradle-plugin 2.0.0-rc
3 participants