[Feature] Sort report totals by counts

18F · Aug 21, 2024 · bf781a3 · bf781a3
1 parent a02ce44
commit bf781a3
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 1 deletion.
diff --git a/reports/usa.json b/reports/usa.json
@@ -81,6 +81,12 @@
           }
         ],
         "orderBys": [
+          {
+            "dimension": {
+              "dimensionName": "date"
+            },
+            "desc": true
+          },
           {
             "metric": {
               "metricName": "totalUsers"

diff --git a/src/process_results/result_totals_calculator.js b/src/process_results/result_totals_calculator.js
@@ -28,6 +28,7 @@ const calculateTotals = (result, options = {}) => {
         column,
         result,
       });
+      totals[`by_${column}`] = _sortObjectByValues(totals[`by_${column}`]);
     }
   }
 
@@ -92,10 +93,14 @@ const _sumMetricByColumn = ({ metric, result, column }) => {
     const category = row[column];
     const count = parseInt(row[metric]);
     categories[category] = (categories[category] || 0) + count;
-    return categories;
+    return _sortObjectByValues(categories);
   }, {});
 };
 
+const _sortObjectByValues = (object) => {
+  return Object.fromEntries(Object.entries(object).sort((a, b) => b[1] - a[1]));
+};
+
 const _sumVisitsByCategoryWithDimension = ({ result, column, dimension }) => {
   return result.data.reduce((categories, row) => {
     const parentCategory = row[column];

diff --git a/test/process_results/result_totals_calculator.test.js b/test/process_results/result_totals_calculator.test.js
@@ -138,6 +138,16 @@ describe("ResultTotalsCalculator", () => {
           it("should compute totals for desktop devices", () => {
             expect(totals.by_device.desktop).to.equal(300 + 600);
           });
+
+          it("sorts totals by visit count", () => {
+            expect(Object.entries(totals.by_device)).to.deep.equal(
+              Object.entries({
+                desktop: 900,
+                tablet: 700,
+                mobile: 500,
+              }),
+            );
+          });
         });
 
         describe("and there are multiple columns being totalled", () => {
@@ -261,6 +271,16 @@ describe("ResultTotalsCalculator", () => {
           it("should compute user totals for desktop devices", () => {
             expect(totals.by_device.desktop).to.equal(300 + 600);
           });
+
+          it("sorts totals by user count", () => {
+            expect(Object.entries(totals.by_device)).to.deep.equal(
+              Object.entries({
+                desktop: 900,
+                tablet: 700,
+                mobile: 500,
+              }),
+            );
+          });
         });
 
         describe("and there are multiple columns being totalled", () => {