Merge pull request #1507 from 18F/mb-set-default-lockout-period

Set a default value for lockout period
18F · Jun 27, 2017 · 5c2ea43 · 5c2ea43
2 parents fc9eb66 + 286c172
commit 5c2ea43
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/app/decorators/user_decorator.rb b/app/decorators/user_decorator.rb
@@ -2,6 +2,7 @@
 
 class UserDecorator
   MAX_RECENT_EVENTS = 5
+  DEFAULT_LOCKOUT_PERIOD = 10.minutes
 
   def initialize(user)
     @user = user
@@ -137,7 +138,12 @@ def masked_number(number)
   end
 
   def lockout_period
-    Figaro.env.lockout_period_in_minutes.to_i.minutes
+    return DEFAULT_LOCKOUT_PERIOD if lockout_period_config.blank?
+    lockout_period_config.to_i.minutes
+  end
+
+  def lockout_period_config
+    @config ||= Figaro.env.lockout_period_in_minutes
   end
 
   def lockout_period_expired?

diff --git a/config/initializers/figaro.rb b/config/initializers/figaro.rb
@@ -10,7 +10,6 @@
   'equifax_ssh_passphrase',
   'hmac_fingerprinter_key',
   'idp_sso_target_url',
-  'lockout_period_in_minutes',
   'logins_per_ip_limit',
   'logins_per_ip_period',
   'max_mail_events',