Changed bit shift logic + added more CI logging

1Git2Clone · Nov 17, 2024 · 67c68ab · 67c68ab
1 parent 0b843a8
commit 67c68ab
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -20,6 +20,6 @@ jobs:
       - name: hw1-test-1
         run: cargo test --verbose --features hw1-test-1
       - name: hw1-test-2
-        run: RUST_BACKTRACE=1 cargo test --verbose --features hw1-test-2
+        run: RUSTFLAGS="-C overflow-checks=on" RUST_BACKTRACE=full cargo test --verbose --features hw1-test-2
       - name: hw1-test-3
         run: cargo test --verbose --features hw1-test-3
diff --git a/src/utils/gcd.rs b/src/utils/gcd.rs
@@ -7,7 +7,7 @@ use num_traits::PrimInt;
 
 pub trait Gcd
 where
-    Self: PrimInt + ShrAssign<u32> + SubAssign,
+    Self: PrimInt + ShrAssign<usize> + SubAssign,
 {
     /// NOTE: Exists for the internal LCM implementation.
     #[deprecated(note = "use crate::utils::gcd::Gcd::gcd() instead.")]
@@ -24,7 +24,7 @@ where
                 swap(&mut self, &mut other)
             }
             other -= self;
-            other >>= other.trailing_zeros();
+            other >>= other.trailing_zeros() as usize;
         }
 
         self << k