[feat] Proposal vote check #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🐛 add missing _pow func to avoid overflow and underflow ✨ helper func in test 🧪 conviction value check after vote and time passed
🎨 better order for test funcs and comments 🎨 some consts added
✨ setCouncilMembers func added ✨ setBasisStakedAmount func added
🐛 fix threshold formula ✨ created better constants for testing 🧪 2 new tests, totalStaked and threshold
🐛 created correct InitializedCV event 🐛 fix subgraph
🔥 replace owner for councilSafe ✨ add AccessControl to use Roles 🔥 remove old ISafe interface in favor of Safe.sol ✨ created SafeSetup for helpers functions ✨ change CouncilSafe ownership in 2 Step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 remove pinned solc version in foundry
🐛 add missing _pow func to avoid overflow and underflow
✨ helper func in test
🧪 conviction value check after vote and time passed
🎨 fix format using forge fmt
🎨 better order for test funcs and comments
🎨 some consts added
🐛 put owner in init params instead msg.sender
✨ setCouncilMembers func added
✨ setBasisStakedAmount func added
🐛 fix stakedAmount updates
🐛 fix threshold formula
✨ created better constants for testing
🧪 2 new tests, totalStaked and threshold