Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit and integration tests #6

Merged
merged 16 commits into from
Jan 23, 2024
Merged

Add unit and integration tests #6

merged 16 commits into from
Jan 23, 2024

Conversation

sam-1pass
Copy link
Contributor

Opening the PR for visibility, test cases are not finished.

@sam-1pass sam-1pass requested a review from AndyTitu January 19, 2024 01:55
@sam-1pass sam-1pass self-assigned this Jan 19, 2024
AndyTitu
AndyTitu reviewed Jan 19, 2024
View reviewed changes
imported_test.go Outdated Show resolved Hide resolved
AndyTitu
AndyTitu reviewed Jan 19, 2024
View reviewed changes
client_test.go Outdated Show resolved Hide resolved
@AndyTitu
Copy link
Contributor

The test cases which have TODO: use valid config should go under integration_test.go. For making those tests pass, you could rebase this PR onto this other one that gives an example of how integration tests can run in the pipeline: #5

@sam-1pass sam-1pass force-pushed the sam/test branch 3 times, most recently from 00de71e to d109e20 Compare January 19, 2024 14:59
@AndyTitu AndyTitu mentioned this pull request Jan 19, 2024
Closed
@AndyTitu AndyTitu changed the base branch from andi_t/add-wasm-approach to andi/add-github-actions January 22, 2024 10:30
@AndyTitu AndyTitu changed the title partially completed test cases Add unit and integration tests Jan 22, 2024
@AndyTitu AndyTitu force-pushed the sam/test branch 2 times, most recently from 054ee28 to 4eaca06 Compare January 22, 2024 12:26
AndyTitu
AndyTitu reviewed Jan 22, 2024
View reviewed changes
client_test.go Outdated Show resolved Hide resolved
AndyTitu
AndyTitu reviewed Jan 22, 2024
View reviewed changes
core_test.go Outdated Show resolved Hide resolved
AndyTitu
AndyTitu reviewed Jan 22, 2024
View reviewed changes
core_test.go Outdated Show resolved Hide resolved
AndyTitu
AndyTitu reviewed Jan 22, 2024
View reviewed changes
core_test.go Outdated Show resolved Hide resolved
AndyTitu
AndyTitu reviewed Jan 22, 2024
View reviewed changes
core_test.go Outdated Show resolved Hide resolved
AndyTitu
AndyTitu reviewed Jan 22, 2024
View reviewed changes
core_test.go Outdated Show resolved Hide resolved
AndyTitu
AndyTitu reviewed Jan 22, 2024
View reviewed changes
client_test.go Outdated Show resolved Hide resolved
AndyTitu
AndyTitu reviewed Jan 22, 2024
View reviewed changes
core_test.go Outdated Show resolved Hide resolved
AndyTitu
AndyTitu reviewed Jan 22, 2024
View reviewed changes
core_test.go Outdated Show resolved Hide resolved
AndyTitu
AndyTitu reviewed Jan 22, 2024
View reviewed changes
core_test.go Outdated Show resolved Hide resolved
AndyTitu
AndyTitu reviewed Jan 22, 2024
View reviewed changes
core_test.go Outdated Show resolved Hide resolved
@AndyTitu AndyTitu force-pushed the andi/add-github-actions branch from b26c100 to a923379 Compare January 22, 2024 14:40
AndyTitu
AndyTitu reviewed Jan 22, 2024
View reviewed changes
core_test.go Outdated Show resolved Hide resolved
AndyTitu
AndyTitu reviewed Jan 22, 2024
View reviewed changes
core_test.go Outdated Show resolved Hide resolved
AndyTitu
AndyTitu reviewed Jan 22, 2024
View reviewed changes
core_test.go Outdated Show resolved Hide resolved
AndyTitu
AndyTitu reviewed Jan 22, 2024
View reviewed changes
core_test.go Outdated Show resolved Hide resolved
AndyTitu
AndyTitu reviewed Jan 22, 2024
View reviewed changes
core_test.go Outdated Show resolved Hide resolved
AndyTitu
AndyTitu reviewed Jan 22, 2024
View reviewed changes
core_test.go Outdated Show resolved Hide resolved
AndyTitu
AndyTitu reviewed Jan 23, 2024
View reviewed changes
client_test.go Outdated Show resolved Hide resolved
AndyTitu
AndyTitu approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@AndyTitu AndyTitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

@AndyTitu AndyTitu merged commit 91f11f1 into andi/add-github-actions Jan 23, 2024
4 checks passed
@AndyTitu AndyTitu deleted the sam/test branch July 31, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyTitu AndyTitu AndyTitu approved these changes

Assignees

@sam-1pass sam-1pass

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sam-1pass @AndyTitu