Style edits to desktop app authentication code comments #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@moward98 The JS version of the desktop auth style edits is ready for review! I wasn't able to find exact parallels of the code comments/error messages from Python, so I'm a little unsure of the placement here. Also, I didn't see this error at all: "Please make sure the Desktop app integration setting is enabled, or contact 1Password support.". Let me know if I missed it, otherwise this MR can just include the one edit describing where to find the account name. |
moward98
approved these changes
Dec 3, 2025
Contributor
moward98
left a comment
moward98
left a comment
There was a problem hiding this comment.
Change looks good to me. I don't see the same error about contacting 1Password support either.
libutcher
commented
Dec 3, 2025
Add account UUID mention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR brings the style edits for desktop app authentication from the Python SDK to JS: 1Password/onepassword-sdk-python#196