Skip to content

Improve paths to SDK IPC lib #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edif2008 merged 2 commits into from
Oct 28, 2025
Merged

Improve paths to SDK IPC lib #185

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e51c95
Improve paths to SDK IPC lib
edif2008 Oct 23, 2025
bb21f71
Remove Windows as a supported operating system
edif2008 Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/onepassword/desktop_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import platform
import base64
from pathlib import Path
from ctypes import c_uint8, c_size_t, c_int32, POINTER, byref, c_void_p

Check failure on line 7 in src/onepassword/desktop_core.py

View workflow job for this annotation

GitHub Actions / Lint

Ruff (F401) 

src/onepassword/desktop_core.py:7:64: F401 `ctypes.c_void_p` imported but unused

Check failure on line 7 in src/onepassword/desktop_core.py

View workflow job for this annotation

GitHub Actions / Lint

Ruff (F401) 

src/onepassword/desktop_core.py:7:64: F401 `ctypes.c_void_p` imported but unused
from onepassword.errors import raise_typed_exception


Expand All @@ -20,15 +20,9 @@
elif os_name == "Linux":
locations = [
"/usr/bin/1password/libop_sdk_ipc_client.so",
"/opt/1password/libop_sdk_ipc_client.so",
"/opt/1Password/libop_sdk_ipc_client.so",
"/snap/bin/1password/libop_sdk_ipc_client.so",
]
elif os_name == "Windows":
locations = [
r"C:\Program Files\1Password\op_sdk_ipc_client.dll",
r"C:\Program Files (x86)\1Password\op_sdk_ipc_client.dll",
str(Path.home() / r"AppData\Local\1Password\op_sdk_ipc_client.dll"),
]
else:
raise OSError(f"Unsupported operating system: {os_name}")

Expand Down
Loading