Conversation
… scoring breakdowns - Removed AINukeEvaluator and its associated methods, consolidating functionality into AINukeHandler. - Introduced NukeScoreBreakdown interface for detailed scoring breakdowns of nuclear targets. - Updated AIConstructionHandler and ConstructionDebugOverlay to utilize new breakdown data. - Adjusted AIPlayerExecution to reflect changes in nuke handling and scoring. - Enhanced debug information with detailed breakdowns for best atom and hydrogen targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the AI construction and nuclear strike evaluation systems, primarily focusing on improving the visibility and debugging of nuke score calculations and removing legacy code. The most significant updates include adding a detailed breakdown of nuke score calculations for debugging purposes, updating the construction debug overlay to display this breakdown, and cleaning up unused code related to the old shared nuke evaluator.
AI Nuke Score Debugging and Calculation Improvements:
Added a new
NukeScoreBreakdowninterface toAINukeHandlerthat provides a detailed breakdown of all inputs to a nuke score calculation, including enemy/friendly structure values, war score, bomb costs, SAM levels, and the final computed score. This breakdown is now stored for the best atom and hydrogen bomb targets. [1] [2] [3] [4]Updated the construction debug overlay (
ConstructionDebugOverlay.ts) to display the detailed nuke score breakdown for both atom and hydrogen bombs, making it easier to understand how the AI evaluates potential nuclear strikes. [1] [2]Codebase Cleanup and Refactoring:
Removed the legacy
AINukeEvaluatorclass and its associated imports, as its functionality has been superseded by the per-playerAINukeHandler. This includes deleting the entiresrc/core/ai/AINukeEvaluator.tsfile and cleaning up references inAIConstructionHandler.ts. [1] [2] [3]Removed the
shouldDeferToNukeslogic and related nuke construction threshold code fromAIConstructionHandler, simplifying the construction decision process and eliminating dependency on the old evaluator. [1] [2] [3]AI Parameter Adjustment:
warshipCoastalThreatWeightparameter inai-profiles.jsonfrom8e4to10e4, slightly increasing the AI's weighting for warship coastal threat assessments.