-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New BloodBuddy #53
base: main
Are you sure you want to change the base?
New BloodBuddy #53
Conversation
… and register.css respectively
You've done a great job but you didn't create any issue so I would have told you what not to do. @dhrjarun |
|
Sorry, closed the pull request by mistake. |
No issues , It looks great just some changes @dhrjarun :
Also, please solve the merge conflicts for this PR to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do the needfull !!
Everything can be done except the no 1. Without sass it will be nightmare writing, organising and mantaining css. So I don't want to write vanilla css for a multipage website like this. |
|
In the tech stack it is HTML CSS & JS . So if you use Sass it may not be possible for other people to contribute to this project and I don't want that. @dhrjarun |
first of all sass is css with some extra features like you can split a single css file into many files and thus organising css becomes easy, therefore if anybody know css, he/she can write styles in sass. And I don't think it will take more than 2-3 days to learn extra features sass gives that css lacks. I think you want the code to be beginner friendly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am really loving the design and want to merge this PR even but just that sass thing cuz then maybe others won't be able to contribute, if you can achieve the same with CSS it works or else, thanks for your efforts !! @dhrjarun
ok, since you like the design, I will remove sass. @2024-SANDHYA |
Replaced sass with css, resolved the conflicts and site is now on github page: https://dhrjarun.github.io/Blood-Buddy/ |
Please don't erase every connected page.Add the previous links in the navbar. @dhrjarun |
This reverts commit 4844ffd.
Hey @dhrjarun Any update on this ? |
see here https://dhrjarun.github.io/Blood-Buddy/, I've added nav for the home page. for other pages I want to improve the design first. @2024-SANDHYA |
@dhrjarun Okay no issues, will it be ready by 2nd Jan? |
@2024-SANDHYA ok, I'll try to complete it before new year. |
Hey @2024-SANDHYA , It is taking me so long, because, I am trying to build a design system and a library of components (like button, slider, switch, input etc). without design system and guidelines everyone gonna come and do whatever he/she thinks is the best, there will be no consistency in it, no consistent colors, typography, spacing, icons, shadows. It will be full of chaos. so to have consistency and to avoid making same component over and over again we need this. Since I am no expert in it and I am doing it for the first time, it's gonna take time. I am not sure how much and I don't wanna work with the deadlines, I just wanna focus on learning. |
Okay no issues, but it is taking a lot of time, not a deadline I am setting but any date you think you'll be able to get that ready @dhrjarun |
2 and a half months @2024-SANDHYA |
That's not how this is gonna work then because this program is for 3 months only from which only 2 months are left. @dhrjarun |
what kind of program? @2024-SANDHYA |
Any update on this @dhrjarun |
Since you didn't reply, I thought of dropping this idea for sometimes. @2024-SANDHYA |
I was talking about SWOC'21 @dhrjarun. Anyway do you want to continue with this now or not? |
what is the deadline? @2024-SANDHYA |
How about till 15th Feb @dhrjarun ? |
ok then, I will try to do as much I can. @2024-SANDHYA |
Hey @2024-SANDHYA, I have designed some pages on figma, I've sent you the link to see. But something has come up and I've to go somewhere so I can't work on coding the pages for may be 3-4 days. |
Changes in Design
changes in code
Here is the link to the website: https://musing-wright-cb475f.netlify.app