Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New BloodBuddy #53

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

New BloodBuddy #53

wants to merge 18 commits into from

Conversation

dhrjarun
Copy link

@dhrjarun dhrjarun commented Dec 8, 2021

GitHub license Open Source Love PRs Welcome

Changes in Design

  • redesigned logo and favicon
  • changed the layout of all three section inside of home page
  • redesigned the about card of home page
  • removed the superhero table
  • designed superhero card (sort of like testimonial) for the superhero section of home page
  • for creating various font sizes, I used modular scale of 1.250

I tried to make the design minimalist and clean

changes in code

  • made the website responsive
  • replaced css with sass for easier maintenance and scaling
  • for sass I used 7-1 architecture (but with little modification)
  • used BEM for class naming convention
  • improved the file structure of images directory
  • used sass map for storing differnet shade of various colors

Here again, I tried to write minimalist and clean code.

Here is the link to the website: https://musing-wright-cb475f.netlify.app

Screenshot 2021-12-08 at 15 39 48

Screenshot 2021-12-08 at 15 40 01

Screenshot 2021-12-08 at 15 40 16

Screenshot 2021-12-08 at 15 40 37

Screenshot 2021-12-08 at 15 41 08

Screenshot 2021-12-08 at 15 41 36

Screenshot 2021-12-08 at 15 41 49

Screenshot 2021-12-08 at 15 42 03

Screenshot 2021-12-08 at 15 42 56

@2024-SANDHYA
Copy link
Owner

GitHub license Open Source Love PRs Welcome

Changes in Design

* redesigned logo and favicon

* changed the layout of all three section inside of home page

* redesigned the about card of home page

* removed the superhero table

* designed superhero card (sort of like testimonial) for the superhero section of home page

* for creating various font sizes, I used modular scale of 1.250

I tried to make the design minimalist and clean

changes in code

* made the website responsive

* replaced css with sass for easier maintenance and scaling

* for sass I used 7-1 architecture (but with little modification)

* used BEM for class naming convention

* improved the file structure of images directory

* used sass map for storing differnet shade of various colors

Here again, I tried to write minimalist and clean code.

Here is the link to the website: https://musing-wright-cb475f.netlify.app

Screenshot 2021-12-08 at 15 39 48 Screenshot 2021-12-08 at 15 40 01 Screenshot 2021-12-08 at 15 40 16 Screenshot 2021-12-08 at 15 40 37 Screenshot 2021-12-08 at 15 41 08 Screenshot 2021-12-08 at 15 41 36 Screenshot 2021-12-08 at 15 41 49 Screenshot 2021-12-08 at 15 42 03 Screenshot 2021-12-08 at 15 42 56

You've done a great job but you didn't create any issue so I would have told you what not to do. @dhrjarun

@dhrjarun
Copy link
Author

dhrjarun commented Dec 8, 2021

GitHub license Open Source Love PRs Welcome

Changes in Design

* redesigned logo and favicon

* changed the layout of all three section inside of home page

* redesigned the about card of home page

* removed the superhero table

* designed superhero card (sort of like testimonial) for the superhero section of home page

* for creating various font sizes, I used modular scale of 1.250

I tried to make the design minimalist and clean

changes in code

* made the website responsive

* replaced css with sass for easier maintenance and scaling

* for sass I used 7-1 architecture (but with little modification)

* used BEM for class naming convention

* improved the file structure of images directory

* used sass map for storing differnet shade of various colors

Here again, I tried to write minimalist and clean code.

Here is the link to the website: https://musing-wright-cb475f.netlify.app
Screenshot 2021-12-08 at 15 39 48
Screenshot 2021-12-08 at 15 40 01
Screenshot 2021-12-08 at 15 40 16
Screenshot 2021-12-08 at 15 40 37
Screenshot 2021-12-08 at 15 41 08
Screenshot 2021-12-08 at 15 41 36
Screenshot 2021-12-08 at 15 41 49
Screenshot 2021-12-08 at 15 42 03
Screenshot 2021-12-08 at 15 42 56

You've done a great job but you didn't create any issue so I would have told you what not to do. @dhrjarun

GitHub license Open Source Love PRs Welcome

Changes in Design

  • redesigned logo and favicon
  • changed the layout of all three section inside of home page
  • redesigned the about card of home page
  • removed the superhero table
  • designed superhero card (sort of like testimonial) for the superhero section of home page
  • for creating various font sizes, I used modular scale of 1.250

I tried to make the design minimalist and clean

changes in code

  • made the website responsive
  • replaced css with sass for easier maintenance and scaling
  • for sass I used 7-1 architecture (but with little modification)
  • used BEM for class naming convention
  • improved the file structure of images directory
  • used sass map for storing differnet shade of various colors

Here again, I tried to write minimalist and clean code.

Here is the link to the website: https://musing-wright-cb475f.netlify.app

Screenshot 2021-12-08 at 15 39 48 Screenshot 2021-12-08 at 15 40 01 Screenshot 2021-12-08 at 15 40 16 Screenshot 2021-12-08 at 15 40 37 Screenshot 2021-12-08 at 15 41 08 Screenshot 2021-12-08 at 15 41 36 Screenshot 2021-12-08 at 15 41 49 Screenshot 2021-12-08 at 15 42 03 Screenshot 2021-12-08 at 15 42 56

GitHub license Open Source Love PRs Welcome

Changes in Design

* redesigned logo and favicon

* changed the layout of all three section inside of home page

* redesigned the about card of home page

* removed the superhero table

* designed superhero card (sort of like testimonial) for the superhero section of home page

* for creating various font sizes, I used modular scale of 1.250

I tried to make the design minimalist and clean

changes in code

* made the website responsive

* replaced css with sass for easier maintenance and scaling

* for sass I used 7-1 architecture (but with little modification)

* used BEM for class naming convention

* improved the file structure of images directory

* used sass map for storing differnet shade of various colors

Here again, I tried to write minimalist and clean code.

Here is the link to the website: https://musing-wright-cb475f.netlify.app
Screenshot 2021-12-08 at 15 39 48
Screenshot 2021-12-08 at 15 40 01
Screenshot 2021-12-08 at 15 40 16
Screenshot 2021-12-08 at 15 40 37
Screenshot 2021-12-08 at 15 41 08
Screenshot 2021-12-08 at 15 41 36
Screenshot 2021-12-08 at 15 41 49
Screenshot 2021-12-08 at 15 42 03
Screenshot 2021-12-08 at 15 42 56

You've done a great job but you didn't create any issue so I would have told you what not to do. @dhrjarun

@dhrjarun dhrjarun closed this Dec 8, 2021
@dhrjarun
Copy link
Author

dhrjarun commented Dec 8, 2021

Sorry, closed the pull request by mistake.
I am new to github, so didn't know about how all this work. @2024-SANDHYA

@dhrjarun dhrjarun reopened this Dec 8, 2021
@2024-SANDHYA
Copy link
Owner

Sorry, close the pull request by mistake. I am new to github, so didn't know about how all this work.

No issues , It looks great just some changes @dhrjarun :

  1. I don't want sass.
  2. Don't host on anything other than Github pages.
  3. Add the navbar back.
  4. Change the logo.
  5. Content alignment is not looking nice

image

Also, please solve the merge conflicts for this PR to be merged.

Copy link
Owner

@2024-SANDHYA 2024-SANDHYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the needfull !!

@dhrjarun
Copy link
Author

dhrjarun commented Dec 8, 2021

Everything can be done except the no 1. Without sass it will be nightmare writing, organising and mantaining css. So I don't want to write vanilla css for a multipage website like this.

@dhrjarun
Copy link
Author

dhrjarun commented Dec 8, 2021

Everything can be done except the no 1. Without sass it will be nightmare writing, organising and mantaining css. So I don't want to write vanilla css for a multipage website like this.

@2024-SANDHYA

@2024-SANDHYA
Copy link
Owner

Everything can be done except the no 1. Without sass it will be nightmare writing, organising and mantaining css. So I don't want to write vanilla css for a multipage website like this.

@2024-SANDHYA

In the tech stack it is HTML CSS & JS . So if you use Sass it may not be possible for other people to contribute to this project and I don't want that. @dhrjarun

@dhrjarun
Copy link
Author

dhrjarun commented Dec 8, 2021

first of all sass is css with some extra features like you can split a single css file into many files and thus organising css becomes easy, therefore if anybody know css, he/she can write styles in sass. And I don't think it will take more than 2-3 days to learn extra features sass gives that css lacks.

I think you want the code to be beginner friendly.
Do whatever you think is the best. @2024-SANDHYA

Copy link
Owner

@2024-SANDHYA 2024-SANDHYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really loving the design and want to merge this PR even but just that sass thing cuz then maybe others won't be able to contribute, if you can achieve the same with CSS it works or else, thanks for your efforts !! @dhrjarun

@dhrjarun
Copy link
Author

dhrjarun commented Dec 11, 2021

ok, since you like the design, I will remove sass. @2024-SANDHYA

@dhrjarun
Copy link
Author

dhrjarun commented Dec 14, 2021

Replaced sass with css, resolved the conflicts and site is now on github page: https://dhrjarun.github.io/Blood-Buddy/
@2024-SANDHYA

@2024-SANDHYA
Copy link
Owner

Replaced sass with css, resolved the conflicts and site is now on github page: https://dhrjarun.github.io/Blood-Buddy/ @2024-SANDHYA

Please don't erase every connected page.Add the previous links in the navbar. @dhrjarun

@2024-SANDHYA
Copy link
Owner

Hey @dhrjarun Any update on this ?

@dhrjarun
Copy link
Author

see here https://dhrjarun.github.io/Blood-Buddy/, I've added nav for the home page. for other pages I want to improve the design first. @2024-SANDHYA

@2024-SANDHYA
Copy link
Owner

2024-SANDHYA commented Dec 24, 2021

see here https://dhrjarun.github.io/Blood-Buddy/, I've added nav for the home page. for other pages I want to improve the design first. @2024-SANDHYA

@dhrjarun Okay no issues, will it be ready by 2nd Jan?

@dhrjarun
Copy link
Author

@2024-SANDHYA ok, I'll try to complete it before new year.

@dhrjarun
Copy link
Author

dhrjarun commented Jan 6, 2022

Hey @2024-SANDHYA , It is taking me so long, because, I am trying to build a design system and a library of components (like button, slider, switch, input etc). without design system and guidelines everyone gonna come and do whatever he/she thinks is the best, there will be no consistency in it, no consistent colors, typography, spacing, icons, shadows. It will be full of chaos. so to have consistency and to avoid making same component over and over again we need this.

Since I am no expert in it and I am doing it for the first time, it's gonna take time. I am not sure how much and I don't wanna work with the deadlines, I just wanna focus on learning.

@2024-SANDHYA
Copy link
Owner

Hey @2024-SANDHYA , It is taking me so long, because, I am trying to build a design system and a library of components (like button, slider, switch, input etc). without design system and guidelines everyone gonna come and do whatever he/she thinks is the best, there will be no consistency in it, no consistent colors, typography, spacing, icons, shadows. It will be full of chaos. so to have consistency and to avoid making same component over and over again we need this.

Since I am no expert in it and I am doing it for the first time, it's gonna take time. I am not sure how much and I don't wanna work with the deadlines, I just wanna focus on learning.

Okay no issues, but it is taking a lot of time, not a deadline I am setting but any date you think you'll be able to get that ready @dhrjarun

@dhrjarun
Copy link
Author

dhrjarun commented Jan 7, 2022

2 and a half months @2024-SANDHYA

@2024-SANDHYA
Copy link
Owner

2 and a half months @2024-SANDHYA

That's not how this is gonna work then because this program is for 3 months only from which only 2 months are left. @dhrjarun

@dhrjarun
Copy link
Author

dhrjarun commented Jan 7, 2022

what kind of program? @2024-SANDHYA

@2024-SANDHYA
Copy link
Owner

what kind of program? @2024-SANDHYA

Any update on this @dhrjarun

@dhrjarun
Copy link
Author

dhrjarun commented Feb 7, 2022

what kind of program? @2024-SANDHYA

Any update on this @dhrjarun

Since you didn't reply, I thought of dropping this idea for sometimes. @2024-SANDHYA

@2024-SANDHYA
Copy link
Owner

what kind of program? @2024-SANDHYA

Any update on this @dhrjarun

Since you didn't reply, I thought of dropping this idea for sometimes. @2024-SANDHYA

I was talking about SWOC'21 @dhrjarun. Anyway do you want to continue with this now or not?

@dhrjarun
Copy link
Author

dhrjarun commented Feb 7, 2022

what kind of program? @2024-SANDHYA

Any update on this @dhrjarun

Since you didn't reply, I thought of dropping this idea for sometimes. @2024-SANDHYA

I was talking about SWOC'21 @dhrjarun. Anyway do you want to continue with this now or not?

what is the deadline? @2024-SANDHYA

@2024-SANDHYA
Copy link
Owner

what kind of program? @2024-SANDHYA

Any update on this @dhrjarun

Since you didn't reply, I thought of dropping this idea for sometimes. @2024-SANDHYA

I was talking about SWOC'21 @dhrjarun. Anyway do you want to continue with this now or not?

what is the deadline? @2024-SANDHYA

How about till 15th Feb @dhrjarun ?

@dhrjarun
Copy link
Author

dhrjarun commented Feb 7, 2022

what kind of program? @2024-SANDHYA

Any update on this @dhrjarun

Since you didn't reply, I thought of dropping this idea for sometimes. @2024-SANDHYA

I was talking about SWOC'21 @dhrjarun. Anyway do you want to continue with this now or not?

what is the deadline? @2024-SANDHYA

How about till 15th Feb @dhrjarun ?

ok then, I will try to do as much I can. @2024-SANDHYA

@dhrjarun
Copy link
Author

Hey @2024-SANDHYA, I have designed some pages on figma, I've sent you the link to see.

But something has come up and I've to go somewhere so I can't work on coding the pages for may be 3-4 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants