Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix delta k in RSD velocity gradients for non-cubic boxes #410

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

daviesje
Copy link
Contributor

@daviesje daviesje commented Aug 1, 2024

@binnietom found a bug in the brightness temperature RSDs which uses the wrong delta k for non-cubic boxes.

Fixes #403

@daviesje daviesje linked an issue Aug 1, 2024 that may be closed by this pull request
@daviesje daviesje marked this pull request as ready for review August 1, 2024 09:28
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.47%. Comparing base (1df46a8) to head (a16376c).
Report is 29 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #410   +/-   ##
=======================================
  Coverage   82.47%   82.47%           
=======================================
  Files          13       13           
  Lines        3121     3121           
  Branches      842      842           
=======================================
  Hits         2574     2574           
  Misses        391      391           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@steven-murray steven-murray merged commit 9c7f6b2 into master Aug 6, 2024
21 checks passed
@steven-murray steven-murray deleted the RSD-noncubic-fix branch August 6, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] NON_CUBIC_FACTOR
2 participants