-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix self closing tags bug in templates fixes (#67) #66
Merged
StartAutomating
merged 5 commits into
2bitdesigns:main
from
ninmonkey:Fix-Self-Closing-tags-bug-in-templates
May 24, 2024
Merged
Fix self closing tags bug in templates fixes (#67) #66
StartAutomating
merged 5 commits into
2bitdesigns:main
from
ninmonkey:Fix-Self-Closing-tags-bug-in-templates
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f-closing element
…f-closing element
…f-closing element
…f-closing element
ninmonkey
changed the title
Fix self closing tags bug in templates
Fix self closing tags bug in templates fixe (#67)
May 20, 2024
The failing test is a docker permission issue: https://github.com/2bitdesigns/4bitcss/actions/runs/9162649149/job/25190036010?pr=66#step:12:425
|
ninmonkey
changed the title
Fix self closing tags bug in templates fixe (#67)
Fix self closing tags bug in templates fixes (#67)
May 20, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 24, 2024
…mplates Fix self closing tags bug in templates fixes (#67)
github-actions bot
pushed a commit
that referenced
this pull request
May 24, 2024
…mplates Fix self closing tags bug in templates fixes (#67)
github-actions bot
pushed a commit
that referenced
this pull request
May 24, 2024
…mplates Fix self closing tags bug in templates fixes (#67)
github-actions bot
pushed a commit
that referenced
this pull request
May 24, 2024
…mplates Fix self closing tags bug in templates fixes (#67)
github-actions bot
pushed a commit
that referenced
this pull request
May 24, 2024
…mplates Fix self closing tags bug in templates fixes (#67)
github-actions bot
pushed a commit
that referenced
this pull request
May 24, 2024
…mplates Fix self closing tags bug in templates fixes (#67)
github-actions bot
pushed a commit
that referenced
this pull request
May 24, 2024
…mplates Fix self closing tags bug in templates fixes (#67)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templates used self closing tags on tags that are not, this breaks the hierarchy.
Fixes #67
Changes are tiny
Despite the file count. 99% of them are a single replacement, without regex.
The remaining files changed were:
see: https://developer.mozilla.org/en-US/docs/Glossary/Void_element#self-closing_tags