Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix self closing tags bug in templates fixes (#67) #66

Conversation

ninmonkey
Copy link
Contributor

@ninmonkey ninmonkey commented May 20, 2024

Templates used self closing tags on tags that are not, this breaks the hierarchy.
Fixes #67

Changes are tiny

Despite the file count. 99% of them are a single replacement, without regex.

nonRegexMatch: "<span class='ColorSchemeFileName' />"
replacement: "<span class='ColorSchemeFileName'></span>"

The remaining files changed were:

  • docs\index.markdown
  • docs\index.md
  • docs\index.ps.markdown

see: https://developer.mozilla.org/en-US/docs/Glossary/Void_element#self-closing_tags

@ninmonkey ninmonkey changed the title Fix self closing tags bug in templates Fix self closing tags bug in templates fixe (#67) May 20, 2024
@ninmonkey
Copy link
Contributor Author

The failing test is a docker permission issue: https://github.com/2bitdesigns/4bitcss/actions/runs/9162649149/job/25190036010?pr=66#step:12:425

> pushing ghcr.io/2bitdesigns/4bitcss:pr-66 with docker:
------
ERROR: denied: installation not allowed to Write organization package
Error: buildx failed with: ERROR: denied: installation not allowed to Write organization package

@ninmonkey ninmonkey changed the title Fix self closing tags bug in templates fixe (#67) Fix self closing tags bug in templates fixes (#67) May 20, 2024
@StartAutomating StartAutomating merged commit 191df01 into 2bitdesigns:main May 24, 2024
2 of 3 checks passed
github-actions bot pushed a commit that referenced this pull request May 24, 2024
…mplates

Fix self closing tags bug in templates fixes (#67)
github-actions bot pushed a commit that referenced this pull request May 24, 2024
…mplates

Fix self closing tags bug in templates fixes (#67)
github-actions bot pushed a commit that referenced this pull request May 24, 2024
…mplates

    Fix self closing tags bug in templates fixes (#67)
github-actions bot pushed a commit that referenced this pull request May 24, 2024
…mplates

    Fix self closing tags bug in templates fixes (#67)
github-actions bot pushed a commit that referenced this pull request May 24, 2024
…mplates

    Fix self closing tags bug in templates fixes (#67)
github-actions bot pushed a commit that referenced this pull request May 24, 2024
…mplates

    Fix self closing tags bug in templates fixes (#67)
github-actions bot pushed a commit that referenced this pull request May 24, 2024
…mplates

    Fix self closing tags bug in templates fixes (#67)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Html output when using self-closing elements
2 participants