Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with older Python versions #18

Merged
merged 3 commits into from
Sep 15, 2024

Conversation

sworisbreathing
Copy link
Contributor

@sworisbreathing sworisbreathing commented Sep 15, 2024

  • add a fallback to typing_extensions when importing Self
  • use pre-3.10 Union types

Hopefully this should fix #17 (at least for 3.9+)

@sworisbreathing sworisbreathing force-pushed the older-python-compatibility branch 3 times, most recently from 9a39a3e to aa367a4 Compare September 15, 2024 14:44
@sworisbreathing sworisbreathing force-pushed the older-python-compatibility branch from aa367a4 to 2c814ed Compare September 15, 2024 14:45
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7cbf31a) to head (3f8e826).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          677       680    +3     
  Branches        56        56           
=========================================
+ Hits           677       680    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this. I should also add older python versions to the CI workflow for verification.

circuitpython_mocks/_mixins.py Outdated Show resolved Hide resolved
@2bndy5
Copy link
Owner

2bndy5 commented Sep 15, 2024

I should also add older python versions to the CI workflow for verification.

I have a branch ready for this, but need this merged first.

@2bndy5 2bndy5 merged commit 0351e41 into 2bndy5:main Sep 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python Compatibility issues
3 participants