III-2490: Make Enum::getAllowedValues() static

2dotstwice · Feb 28, 2018 · db758ff · db758ff
1 parent 83a8dc8
commit db758ff
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/src/String/Enum.php b/src/String/Enum.php
@@ -18,25 +18,28 @@ final public function __construct($value)
         $this->setValue($value);
     }
 
-    /**
-     * @return string[]
-     */
-    abstract protected function getAllowedValues();
-
     /**
      * @param string $value
      * @throws \InvalidArgumentException
      */
     private function guardAllowedValue($value)
     {
-        $allowed = $this->getAllowedValues();
+        $allowed = static::getAllowedValues();
         if (!in_array($value, $allowed)) {
             throw new \InvalidArgumentException(
                 "Encountered unknown value '{$value}'. Allowed values: " . implode(', ', $allowed)
             );
         }
     }
 
+    /**
+     * @return string[]
+     */
+    public static function getAllowedValues()
+    {
+        return [];
+    }
+
     /**
      * @param string $name
      * @param array $arguments

diff --git a/tests/String/MockEnum.php b/tests/String/MockEnum.php
@@ -11,7 +11,7 @@ class MockEnum extends Enum
     /**
      * @return string[]
      */
-    public function getAllowedValues()
+    public static function getAllowedValues()
     {
         return [
             'foo',