-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to localized homepage template for UNITEFA-CONICET #2871
Conversation
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
@jmunroe, I left a couple of comments to 2i2c-org/default-hub-homepage@57f46d9 to the best of my Spanish knowledge (which is not extensive :D ), but it looks good to me overall. Nonetheless, I invite feedback from @damianavila to 2i2c-org/default-hub-homepage@57f46d9. Btw, I also temp deployed it to the staging hub and it looks pretty cool to me https://staging.2i2c.cloud (the change might get overridden soon though) |
@jmunroe @damianavila what do we do with this PR? |
This will require additional work before it can be merged. Closing without merging. |
fc458dd
to
845287c
Compare
The additional work of getting a professional translator (using Crowdin) has now been completed. It think this PR is ready to be merged so it can be shown to the UNITEFA community champions |
Tested deploy and get 500 errors. Rolled back the deployment and will try and resolve before merging. |
There were issues with Crowdin messing up the Jinga2 templating. Fixed those and deploying now works as expected. |
I've also changed the template login page for the staging site on this cluster as well. I'll await a review before merging because I am touching two "sites" before merging. |
See #2870 . Need to verify that the Spanish translation is at least passable before merging.
Note by Georgiana: The Spanish translation lives at 2i2c-org/default-hub-homepage@57f46d9