Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to localized homepage template for UNITEFA-CONICET #2871

Closed
wants to merge 5 commits into from

Conversation

jmunroe
Copy link
Contributor

@jmunroe jmunroe commented Jul 25, 2023

See #2870 . Need to verify that the Spanish translation is at least passable before merging.

Note by Georgiana: The Spanish translation lives at 2i2c-org/default-hub-homepage@57f46d9

@jmunroe jmunroe requested a review from a team as a code owner July 25, 2023 18:28
@github-actions
Copy link

github-actions bot commented Jul 25, 2023

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
gcp catalystproject-latam No Yes Following helm chart values files were modified: staging.values.yaml

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
gcp catalystproject-latam unitefa-conicet Following helm chart values files were modified: unitefa-conicet.values.yaml

@GeorgianaElena
Copy link
Member

@jmunroe, I left a couple of comments to 2i2c-org/default-hub-homepage@57f46d9 to the best of my Spanish knowledge (which is not extensive :D ), but it looks good to me overall.

Nonetheless, I invite feedback from @damianavila to 2i2c-org/default-hub-homepage@57f46d9.

Btw, I also temp deployed it to the staging hub and it looks pretty cool to me https://staging.2i2c.cloud (the change might get overridden soon though)

@yuvipanda
Copy link
Member

@jmunroe @damianavila what do we do with this PR?

@jmunroe
Copy link
Contributor Author

jmunroe commented Sep 11, 2023

This will require additional work before it can be merged.

Closing without merging.

@jmunroe jmunroe closed this Sep 11, 2023
@jmunroe jmunroe reopened this Nov 8, 2023
@jmunroe jmunroe force-pushed the jmunroe-catalystproject-es branch from fc458dd to 845287c Compare November 8, 2023 17:54
@jmunroe
Copy link
Contributor Author

jmunroe commented Nov 8, 2023

The additional work of getting a professional translator (using Crowdin) has now been completed. It think this PR is ready to be merged so it can be shown to the UNITEFA community champions

@jmunroe
Copy link
Contributor Author

jmunroe commented Nov 8, 2023

Tested deploy and get 500 errors. Rolled back the deployment and will try and resolve before merging.

@jmunroe
Copy link
Contributor Author

jmunroe commented Nov 8, 2023

There were issues with Crowdin messing up the Jinga2 templating. Fixed those and deploying now works as expected.

@jmunroe
Copy link
Contributor Author

jmunroe commented Nov 8, 2023

I've also changed the template login page for the staging site on this cluster as well.

I'll await a review before merging because I am touching two "sites" before merging.

@jmunroe jmunroe closed this Jun 24, 2024
@jmunroe jmunroe deleted the jmunroe-catalystproject-es branch June 24, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

4 participants