-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grant access for 2i2c members only via admin_users #3233
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,5 +43,3 @@ jupyterhub: | |
http://google.com/accounts/o8/id: | ||
username_derivation: | ||
username_claim: "email" | ||
allowed_domains: | ||
- "2i2c.org" | ||
Comment on lines
-46
to
-47
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removing ourselves from a CILogonOAuthenticator |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,5 +41,4 @@ jupyterhub: | |
username_derivation: | ||
username_claim: "email" | ||
allowed_domains: | ||
- "2i2c.org" | ||
- "rmbl.org" | ||
- rmbl.org |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,18 +36,16 @@ jupyterhub: | |
CILogonOAuthenticator: | ||
oauth_callback_url: "https://mtu.2i2c.cloud/hub/oauth_callback" | ||
allowed_idps: | ||
# Allow 2i2c staff to login with Google | ||
http://google.com/accounts/o8/id: | ||
username_derivation: | ||
username_claim: "email" | ||
allowed_domains: | ||
- "2i2c.org" | ||
# Allow MTU to login via Shibboleth | ||
https://sso.mtu.edu/idp/shibboleth: | ||
username_derivation: | ||
username_claim: "email" | ||
allowed_domains: | ||
- "mtu.edu" | ||
# Allow 2i2c staff to login with Google accounts | ||
http://google.com/accounts/o8/id: | ||
username_derivation: | ||
username_claim: "email" | ||
Comment on lines
-39
to
+48
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was a re-ordering of config entries. I want us to put the user-facing idp's first as a way to prepare for letting that lead to presenting that option by default in favor of presenting the option only relevant to us admin first. For more details about this, see jupyterhub/oauthenticator#690 |
||
Authenticator: | ||
admin_users: | ||
- "dbkc@mtu.edu" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,9 @@ jupyterhub: | |
enabled: true | ||
custom: | ||
2i2c: | ||
# add_staff_user_ids_to_admin_users is disabled because the usernames | ||
# aren't github id or email based, individual 2i2c members have added | ||
# their user to admin_users manually instead. | ||
add_staff_user_ids_to_admin_users: false | ||
# add_staff_user_ids_of_type: "google" | ||
Comment on lines
+22
to
26
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In this hub where we aren't added to admin_users, it remains important to not remove allowing us via |
||
homepage: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,8 +39,7 @@ basehub: | |
authenticator_class: github | ||
GitHubOAuthenticator: | ||
populate_teams_in_auth_state: true | ||
allowed_organizations: &allowed_github_orgs | ||
- 2i2c-org | ||
allowed_organizations: | ||
- smithsonian | ||
- sidatasciencelab | ||
- Smithsonian-SDCH | ||
|
@@ -76,7 +75,6 @@ basehub: | |
description: &profile_list_description "Start a container with at least a chosen share of capacity on a node of this type" | ||
slug: small | ||
default: true | ||
allowed_teams: *allowed_github_orgs | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Its better if we just allow all users by default instead, because otherwise we need to make a few extra API calls to check for membership etc for no real reason. Since #3234 (comment), removing |
||
profile_options: | ||
image: &profile_options_image | ||
display_name: Image | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing ourselves from
allowed_organization
is fine, because we are added toadmin_users
.Doing this also isn't influencing the filtering of profile_list entries using our basehub injected
allowed_teams
config.