Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support, grafana: configure enable_gzip true #3253

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

consideRatio
Copy link
Contributor

@consideRatio consideRatio commented Oct 11, 2023

The grafana documentation mentions that this was only set to false because of compatebility reasons, but its recommended to be true for most users.

image

I test deployed this to grafana.qcl.2i2c.cloud and things seem to work fine still.


Misc extras

None of these things should change any final configuration values of the chart.

  • I added some comments to support chart's grafana config
  • I removed redundant config about psp now deprecated/removed in k8s
  • I added explicitly what the default pvc size was, as its actually 10Gi and not 1Gi as stated by a comment

The grafana documentation mentions that this was only set to false
because of compatebility reasons, but its recommended to be true for
most users.
@consideRatio consideRatio requested a review from a team as a code owner October 11, 2023 12:35
@consideRatio consideRatio added the nominated-to-be-resolved-during-q4-2023 Nomination to be resolved during q4 goal of reducing the technical debt label Oct 11, 2023
@github-actions
Copy link

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
kubeconfig utoronto Yes Support helm chart has been modified No
gcp leap Yes Support helm chart has been modified No
aws 2i2c-aws-us Yes Support helm chart has been modified No
gcp callysto Yes Support helm chart has been modified No
aws ubc-eoas Yes Support helm chart has been modified No
aws nasa-veda Yes Support helm chart has been modified No
gcp qcl Yes Support helm chart has been modified No
aws catalystproject-africa Yes Support helm chart has been modified No
gcp cloudbank Yes Support helm chart has been modified No
aws nasa-cryo Yes Support helm chart has been modified No
aws victor Yes Support helm chart has been modified No
gcp m2lines Yes Support helm chart has been modified No
gcp pangeo-hubs Yes Support helm chart has been modified No
aws openscapes Yes Support helm chart has been modified No
gcp 2i2c-uk Yes Support helm chart has been modified No
aws nasa-ghg Yes Support helm chart has been modified No
gcp linked-earth Yes Support helm chart has been modified No
gcp meom-ige Yes Support helm chart has been modified No
aws carbonplan Yes Support helm chart has been modified No
aws smithsonian Yes Support helm chart has been modified No
gcp catalystproject-latam Yes Support helm chart has been modified No
gcp hhmi Yes Support helm chart has been modified No
aws gridsst Yes Support helm chart has been modified No
gcp 2i2c Yes Support helm chart has been modified No
aws jupyter-meets-the-earth Yes Support helm chart has been modified No
gcp awi-ciroh Yes Support helm chart has been modified No

Production deployments

No production hub upgrades will be triggered

@consideRatio consideRatio merged commit 4c867a6 into 2i2c-org:master Oct 18, 2023
@github-actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/6557254737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nominated-to-be-resolved-during-q4-2023 Nomination to be resolved during q4 goal of reducing the technical debt
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

2 participants