-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qcl, awi-ciroh, leap, 2i2c: gke k8s clusters upgraded to 1.27 #3375
qcl, awi-ciroh, leap, 2i2c: gke k8s clusters upgraded to 1.27 #3375
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
84fc8c9
to
e53a558
Compare
1b76fac
to
388eae8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing these upgrades @consideRatio
}, | ||
"n2-highmem-64" : { | ||
min : 0, | ||
max : 100, | ||
machine_type : "n2-highmem-64" | ||
} | ||
# FIXME: Remove node pool specific node_version pin when given the chance and no such nodes are running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the pin + terraform apply will delete the current node pool and recreate one with the newest k8s version? Or are extra steps needed to upgrade these machine types' k8s version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When node_version
is removed, it will result in a rolling upgrade. If users pods are active on the node pool's nodes, then they will be terminated or the rolling upgrade will fail.
Due to this, we should wait for no users to be on the node before doing this.
GKE sais its okay that a node pool is 2 minor versions behind the control plane / k8s api-server though, so for now this is okay.
a5c9cf5
to
1edc5b7
Compare
1edc5b7
to
b8090f0
Compare
Thank you @GeorgianaElena!! I rebased this on two other PRs merged, but otherwise since your review I only removed a fixme note that you caught to be resolved (b8090f0). |
These clusters were opportunistically upgraded as part of me trying to gain experience to document an upgrade policy for GKE clusters (#3250).
Semi-related extras
388eae8 - I used
deployer generate resource-allocation daemonset-requests <cluster name>
to update information about daemonsets' resource requests in clusters as welld1e193d - I made the deploy hubs workflow not redeploy all hubs because of changes to unrelated
generate
commands not used in the workflow