Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qcl, awi-ciroh, leap, 2i2c: gke k8s clusters upgraded to 1.27 #3375

Merged
merged 9 commits into from
Nov 6, 2023

Conversation

consideRatio
Copy link
Contributor

@consideRatio consideRatio commented Nov 4, 2023

These clusters were opportunistically upgraded as part of me trying to gain experience to document an upgrade policy for GKE clusters (#3250).

Semi-related extras

388eae8 - I used deployer generate resource-allocation daemonset-requests <cluster name> to update information about daemonsets' resource requests in clusters as well

d1e193d - I made the deploy hubs workflow not redeploy all hubs because of changes to unrelated generate commands not used in the workflow

@consideRatio consideRatio requested a review from a team as a code owner November 4, 2023 21:08
@consideRatio consideRatio changed the title qcl, awi-ciroh: gke k8s clusters upgraded to 1.27 qcl and awi-ciroh: gke k8s clusters upgraded to 1.27 Nov 4, 2023

This comment was marked as resolved.

@consideRatio

This comment was marked as outdated.

@consideRatio consideRatio changed the title qcl and awi-ciroh: gke k8s clusters upgraded to 1.27 qcl, awi-ciroh, leap: gke k8s clusters upgraded to 1.27 Nov 5, 2023
@consideRatio consideRatio marked this pull request as draft November 5, 2023 12:00
@consideRatio consideRatio force-pushed the pr/upgrade-qcl-awi-ciroh branch from 84fc8c9 to e53a558 Compare November 5, 2023 16:26
@consideRatio consideRatio marked this pull request as ready for review November 5, 2023 16:27
@consideRatio consideRatio force-pushed the pr/upgrade-qcl-awi-ciroh branch 5 times, most recently from 1b76fac to 388eae8 Compare November 5, 2023 18:02
@consideRatio consideRatio changed the title qcl, awi-ciroh, leap: gke k8s clusters upgraded to 1.27 qcl, awi-ciroh, leap, 2i2c: gke k8s clusters upgraded to 1.27 Nov 5, 2023
Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing these upgrades @consideRatio

},
"n2-highmem-64" : {
min : 0,
max : 100,
machine_type : "n2-highmem-64"
}
# FIXME: Remove node pool specific node_version pin when given the chance and no such nodes are running
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the pin + terraform apply will delete the current node pool and recreate one with the newest k8s version? Or are extra steps needed to upgrade these machine types' k8s version?

Copy link
Contributor Author

@consideRatio consideRatio Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When node_version is removed, it will result in a rolling upgrade. If users pods are active on the node pool's nodes, then they will be terminated or the rolling upgrade will fail.

Due to this, we should wait for no users to be on the node before doing this.

GKE sais its okay that a node pool is 2 minor versions behind the control plane / k8s api-server though, so for now this is okay.

terraform/gcp/projects/pilot-hubs.tfvars Outdated Show resolved Hide resolved
@consideRatio consideRatio force-pushed the pr/upgrade-qcl-awi-ciroh branch from a5c9cf5 to 1edc5b7 Compare November 6, 2023 10:55
@consideRatio consideRatio force-pushed the pr/upgrade-qcl-awi-ciroh branch from 1edc5b7 to b8090f0 Compare November 6, 2023 10:57
@consideRatio consideRatio merged commit b2b2186 into 2i2c-org:master Nov 6, 2023
@consideRatio
Copy link
Contributor Author

Thank you @GeorgianaElena!!

I rebased this on two other PRs merged, but otherwise since your review I only removed a fixme note that you caught to be resolved (b8090f0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

3 participants