GCP: Allow public access to buckets via IAM, not ACL #3383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were mixing ACL and IAM, which led to basically the bucket *not* being accessible publicly - only to authenticated users. This switches everything to using IAM, which *does* make the bucket properly publicly accessible. In addition, there's now a policy that we only enable this when 2i2c is *not* handling billing, as there can be disastrous cost consequences. We fix this for the LEAP bucket. Config is moved to `user_buckets` rather than `hub_permissions`, as the config is purely set on the bucket and not related to which hub we are configuring. Ref https://2i2c.freshdesk.com/a/tickets/954
|
I've applied this for LEAP and tested that it works |
consideRatio
approved these changes
Nov 6, 2023
yuvipanda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were mixing ACL and IAM, which led to basically the bucket not being accessible publicly - only to authenticated users.
This switches everything to using IAM, which does make the bucket properly publicly accessible.
In addition, there's now a policy that we only enable this when 2i2c is not handling billing, as there can be disastrous cost consequences.
We fix this for the LEAP bucket.
Config is moved to
user_bucketsrather thanhub_permissions, as the config is purely set on the bucket and not related to which hub we are configuring.Ref https://2i2c.freshdesk.com/a/tickets/954