Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform, gcp: add opt-out var to collaboratively and opportunistically apply node-purpose infra labels #3406

Merged

Conversation

consideRatio
Copy link
Contributor

@consideRatio consideRatio commented Nov 13, 2023

This is for #3405, a followup to #3397 that is work I think all @2i2c-org/engineering needs to opportunistically apply over time when given the chance. @2i2c-org/engineering the ask is that when you apply terraform config, consider if there are a fixme that you'd like to opportunistically resolve while you are at it.

This PR adds variables and fixme notes in individual GCP clusters' .tfvar files, allowing us to see where we haven't yet managed to apply what #3397 introduced.

The purpose of this is to:

  • ensure our terraform state is reflect in our config
  • set us up to collectively and opportunistically work towards the desired state over time
  • unblock other changes that may not be disruptive in the terraform config

Copy link
Member

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty clever, thanks for doing this @consideRatio.

I've just applied tf to pangeo-hubs (and ticked it off in the PR I was using to track) so can you remove that from here before merging?

@consideRatio consideRatio force-pushed the pr/opt-out-node-purpose-infra-labels branch from 908205d to f152e57 Compare November 13, 2023 08:16
@consideRatio
Copy link
Contributor Author

I've just applied tf to pangeo-hubs (and ticked it off in the PR I was using to track) so can you remove that from here before merging?

Ah nice @yuvipanda, I rebased and removed that commit!

@consideRatio
Copy link
Contributor Author

Thank you for reviewing and working on this @yuvipanda!!

@consideRatio consideRatio merged commit 77ef03a into 2i2c-org:master Nov 13, 2023
1 check passed
@consideRatio
Copy link
Contributor Author

Argh, removed pilot-hubs instead of pangeo-hubs... =/ I'll open a new PR to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

2 participants