Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leap, 2i2c, cloudbank: Cleanup some unused nodepools #3537

Merged
merged 7 commits into from
Dec 18, 2023
Merged

leap, 2i2c, cloudbank: Cleanup some unused nodepools #3537

merged 7 commits into from
Dec 18, 2023

Conversation

yuvipanda
Copy link
Member

@yuvipanda yuvipanda commented Dec 16, 2023 •
edited
Loading

  • Also removes the temp opt out variable in use
  • Also handles a FIXME about core node size on cloudbank. This brought us from 2
    n2-highmem-4 nodes to 3 n2-highmem-2 nodes, which is cheaper by 25%!

Fixes #3405

These changes have all been applied

@yuvipanda yuvipanda requested a review from a team as a code owner December 16, 2023 03:29
@yuvipanda yuvipanda changed the title leap, 2i2c: Cleanup some unused nodepools leap, 2i2c, cloudbank: Cleanup some unused nodepools Dec 17, 2023
@yuvipanda
Copy link
Member Author

Self merging as there aren't any other engineers around until end of year.

@yuvipanda yuvipanda merged commit fba213a into 2i2c-org:master Dec 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yuvipanda yuvipanda

Labels
None yet
Projects
No open projects
Sprint Board
Status: Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collaboratively and incrementally introduce node-purpose resource label
1 participant
@yuvipanda