NShiftKey

• Use try-with-resources or close this "Stream" in a "finally" clause.

  • Description : https://rules.sonarsource.com/java/RSPEC-2095/
    • Target Code : NationalSecurityAgency-datawave/warehouse/age-off-utils/src/test/java/datawave/age/off/util/AgeOffCsvToMatchPatternFormatterTest.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/age-off-utils/src/test/java/datawave/age/off/util/AgeOffCsvToMatchPatternFormatterTest.java

      Lines 381 to 383 in 012eeed

      	File file = new File(AgeOffCsvToMatchPatternFormatterTest.class.getResource(SHELF_LIFE_FILE_IN).toURI());
      	Iterator<String> lineIterator = Files.lines(file.toPath()).iterator();
      	return builder.setInput(lineIterator);

      
        

• Use try-with-resources or close this "BufferedInputStream" in a "finally" clause.

  • Description : https://rules.sonarsource.com/java/RSPEC-2095/
    • Target Code : NationalSecurityAgency-datawave/warehouse/core/src/test/java/datawave/edge/util/EdgeValueTest.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/core/src/test/java/datawave/edge/util/EdgeValueTest.java

      Lines 197 to 199 in 012eeed

      	InputStream istream = new BufferedInputStream(new FileInputStream(file));
      	ByteArrayOutputStream bytes = new ByteArrayOutputStream();

      
        

• Add an end condition to this loop.

  • Description : https://rules.sonarsource.com/java/RSPEC-2189/
    • Target Code : NationalSecurityAgency-datawave/web-services/query/src/main/java/datawave/webservice/query/util/LookupUUIDUtil.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/web-services/query/src/main/java/datawave/webservice/query/util/LookupUUIDUtil.java

      Lines 919 to 921 in 012eeed

      	EventQueryResponseBase eventResponse = null;
      	do {
      	final BaseQueryResponse nextResponse = this.queryExecutor.next(queryId);

      
        
    • Target Code : NationalSecurityAgency-datawave/warehouse/query-core/src/test/java/datawave/query/util/sortedset/MergeSortIteratorTest.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/query-core/src/test/java/datawave/query/util/sortedset/MergeSortIteratorTest.java

      Lines 127 to 129 in 012eeed

      	MergeSortIterator<Integer> it = new MergeSortIterator<>(col);
      	while (true) {
      	try {

      
        

• Use try-with-resources or close this "ServerSocket" in a "finally" clause.

  • Description : https://rules.sonarsource.com/java/RSPEC-2095/
    • Target Code : NationalSecurityAgency-datawave/warehouse/ingest-core/src/main/java/datawave/ingest/mapreduce/job/BulkIngestMapFileLoader.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/ingest-core/src/main/java/datawave/ingest/mapreduce/job/BulkIngestMapFileLoader.java

      Lines 411 to 413 in 012eeed

      	if (shutdownPort > 0) {
      	final ServerSocket serverSocket = new ServerSocket(shutdownPort);
      	Runnable shutdownListener = () -> listenForShutdownCommand(serverSocket);

      
        

• Use try-with-resources or close this "BufferedReader" in a "finally" clause.

  • Description : https://rules.sonarsource.com/java/RSPEC-2095/
    • Target Code : NationalSecurityAgency-datawave/warehouse/ingest-core/src/test/java/datawave/ingest/mapreduce/partition/TabletLocationNamePartitionerTest.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/ingest-core/src/test/java/datawave/ingest/mapreduce/partition/TabletLocationNamePartitionerTest.java

      Lines 51 to 53 in 012eeed

      	conf.set(TableSplitsCache.SPLITS_CACHE_FILE, "shards_n_locs.list");
      	BufferedReader reader = new BufferedReader(new InputStreamReader(file.openStream()));
      	String line = reader.readLine();

      
        

• Use try-with-resources or close this "FileOutputStream" in a "finally" clause.

  • Description : https://rules.sonarsource.com/java/RSPEC-2095/
    • Target Code : NationalSecurityAgency-datawave/warehouse/query-core/src/test/java/datawave/query/util/TypeMetadataTest.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/query-core/src/test/java/datawave/query/util/TypeMetadataTest.java

      Lines 86 to 88 in 012eeed

      	final File tempFile = new File(tempDir, "type_metadata_roundtrip_test");
      	FileOutputStream fos = new FileOutputStream(tempFile);
      	ObjectOutputStream oos = new ObjectOutputStream(fos);

      
        

• Use try-with-resources or close this "FileInputStream" in a "finally" clause.

  • Description : https://rules.sonarsource.com/java/RSPEC-2095/
    • Target Code : NationalSecurityAgency-datawave/warehouse/query-core/src/test/java/datawave/query/util/TypeMetadataTest.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/query-core/src/test/java/datawave/query/util/TypeMetadataTest.java

      Lines 91 to 93 in 012eeed

      	FileInputStream fis = new FileInputStream(tempFile);
      	ObjectInputStream ois = new ObjectInputStream(fis);

      
        

• Remove this dangerous instance of double-checked locking.

  • Description : https://rules.sonarsource.com/java/RSPEC-2168/
    • Target Code : NationalSecurityAgency-datawave/warehouse/ingest-core/src/main/java/datawave/ingest/data/TypeRegistry.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/ingest-core/src/main/java/datawave/ingest/data/TypeRegistry.java

      Lines 65 to 67 in 012eeed

      	if (null == registry) {
      	synchronized (lock) {
      	if (null == registry) {

      
        
    • Target Code : NationalSecurityAgency-datawave/warehouse/query-core/src/main/java/datawave/query/statsd/QueryStatsDClient.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/query-core/src/main/java/datawave/query/statsd/QueryStatsDClient.java

      Lines 64 to 66 in 012eeed

      	if (this.client == null) {
      	synchronized (clientMonitor) {
      	if (this.client == null) {

      
        
    • Target Code : NationalSecurityAgency-datawave/warehouse/query-core/src/main/java/datawave/query/tracking/ActiveQueryLog.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/query-core/src/main/java/datawave/query/tracking/ActiveQueryLog.java

      Lines 95 to 97 in 012eeed

      	if (ActiveQueryLog.logCache == null) {
      	synchronized (ActiveQueryLog.logCacheLock) {
      	if (ActiveQueryLog.logCache == null) {

      
        
    • Target Code : NationalSecurityAgency-datawave/warehouse/age-off/src/main/java/datawave/iterators/filter/ConfigurableAgeOffFilter.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/age-off/src/main/java/datawave/iterators/filter/ConfigurableAgeOffFilter.java

      Lines 469 to 471 in 012eeed

      	if (null == fs) {
      	synchronized (ConfigurableAgeOffFilter.class) {
      	if (null == fs) {

      
        
    • Target Code : NationalSecurityAgency-datawave/warehouse/age-off/src/main/java/datawave/iterators/filter/ConfigurableAgeOffFilter.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/age-off/src/main/java/datawave/iterators/filter/ConfigurableAgeOffFilter.java

      Lines 439 to 441 in 012eeed

      	if (null == ruleCache) {
      	synchronized (ConfigurableAgeOffFilter.class) {
      	if (null == ruleCache) {

      
        
    • Target Code : NationalSecurityAgency-datawave/warehouse/ingest-core/src/main/java/datawave/ingest/time/Now.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/ingest-core/src/main/java/datawave/ingest/time/Now.java

      Lines 38 to 40 in 012eeed

      	if (instance == null) {
      	synchronized (Now.class) {
      	if (instance == null) {

      
        

• Use try-with-resources or close this "ObjectInputStream" in a "finally" clause.

  • Description : https://rules.sonarsource.com/java/RSPEC-2095/
    • Target Code : NationalSecurityAgency-datawave/warehouse/query-core/src/test/java/datawave/query/util/TypeMetadataTest.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/query-core/src/test/java/datawave/query/util/TypeMetadataTest.java

      Lines 92 to 94 in 012eeed

      	FileInputStream fis = new FileInputStream(tempFile);
      	ObjectInputStream ois = new ObjectInputStream(fis);
      	Object got = ois.readObject();

      
        

• Use try-with-resources or close this "DatagramSocket" in a "finally" clause.

  • Description : https://rules.sonarsource.com/java/RSPEC-2095/
    • Target Code : NationalSecurityAgency-datawave/warehouse/query-core/src/test/java/datawave/query/statsd/QueryStatsdDClientTest.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/query-core/src/test/java/datawave/query/statsd/QueryStatsdDClientTest.java

      Lines 154 to 156 in 012eeed

      	try {
      	DatagramSocket serverSocket = new DatagramSocket(port);
      	running = true;

      
        

• Use try-with-resources or close this "ObjectOutputStream" in a "finally" clause.

  • Description : https://rules.sonarsource.com/java/RSPEC-2095/
    • Target Code : NationalSecurityAgency-datawave/warehouse/query-core/src/test/java/datawave/query/util/TypeMetadataTest.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/query-core/src/test/java/datawave/query/util/TypeMetadataTest.java

      Lines 87 to 89 in 012eeed

      	FileOutputStream fos = new FileOutputStream(tempFile);
      	ObjectOutputStream oos = new ObjectOutputStream(fos);
      	oos.writeObject(map);

      
        

• Replace the call to "Thread.sleep(...)" with a call to "wait(...)".

  • Description : https://rules.sonarsource.com/java/RSPEC-2276/
    • Target Code : NationalSecurityAgency-datawave/warehouse/query-core/src/main/java/datawave/mr/bulk/RecordIterator.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/query-core/src/main/java/datawave/mr/bulk/RecordIterator.java

      Lines 562 to 564 in 012eeed

      	try {
      	Thread.sleep(failureSleep);
      	} catch (InterruptedException e) {

      
        
    • Target Code : NationalSecurityAgency-datawave/warehouse/query-core/src/main/java/datawave/query/planner/ThreadedRangeBundlerIterator.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/query-core/src/main/java/datawave/query/planner/ThreadedRangeBundlerIterator.java

      Lines 133 to 135 in 012eeed

      	&& (startTimeMillis + rangeBufferTimeoutMillis) > System.currentTimeMillis() && !rangeConsumer.isStopped()) {
      	Thread.sleep(rangeBufferPollMillis);
      	}

      
        

• Use try-with-resources or close this "BufferedOutputStream" in a "finally" clause.

  • Description : https://rules.sonarsource.com/java/RSPEC-2095/
    • Target Code : NationalSecurityAgency-datawave/warehouse/core/src/test/java/datawave/edge/util/EdgeValueTest.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/core/src/test/java/datawave/edge/util/EdgeValueTest.java

      Lines 193 to 195 in 012eeed

      	File file = File.createTempFile("EdgeValueTest", "bytes");
      	OutputStream stream = new BufferedOutputStream(new FileOutputStream(file));
      	stream.write(value.get(), 0, value.getSize());

      
        

• Remove or replace this boundary that will never match because it appears before mandatory input.

  • Description : https://rules.sonarsource.com/java/RSPEC-5996/
    • Target Code : NationalSecurityAgency-datawave/web-services/map-reduce/src/main/java/datawave/webservice/mr/configuration/MapReduceJobConfiguration.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/web-services/map-reduce/src/main/java/datawave/webservice/mr/configuration/MapReduceJobConfiguration.java

      Lines 439 to 441 in 012eeed

      	int fileCount = 0;
      	String outputName = source.replaceAll("/", "_").replaceFirst("$_", "") + ".jar";
      	Path destination = new Path(classpath, outputName);

      
        

• Remove this throw statement from this finally block.

  • Description : https://rules.sonarsource.com/java/RSPEC-1143/
    • Target Code : NationalSecurityAgency-datawave/web-services/model/src/main/java/datawave/webservice/query/model/ModelBean.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/web-services/model/src/main/java/datawave/webservice/query/model/ModelBean.java

      Lines 518 to 520 in 012eeed

      	response.addException(qe);
      	throw new DatawaveWebApplicationException(qe, response);
      	}

      
        
    • Target Code : NationalSecurityAgency-datawave/web-services/model/src/main/java/datawave/webservice/query/model/ModelBean.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/web-services/model/src/main/java/datawave/webservice/query/model/ModelBean.java

      Lines 445 to 447 in 012eeed

      	response.addException(qe);
      	throw new DatawaveWebApplicationException(qe, response);
      	}

      
        
    • Target Code : NationalSecurityAgency-datawave/web-services/query/src/main/java/datawave/webservice/query/runner/QueryExecutorBean.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/web-services/query/src/main/java/datawave/webservice/query/runner/QueryExecutorBean.java

      Lines 1329 to 1331 in 012eeed

      	response.addException(qe.getBottomQueryException());
      	throw new DatawaveWebApplicationException(qe, response);
      	}

      
        
    • Target Code : NationalSecurityAgency-datawave/web-services/query/src/main/java/datawave/webservice/query/runner/QueryExecutorBean.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/web-services/query/src/main/java/datawave/webservice/query/runner/QueryExecutorBean.java

      Lines 907 to 909 in 012eeed

      	response.addException(qe);
      	throw qe;
      	}

      
        
    • Target Code : NationalSecurityAgency-datawave/web-services/query/src/main/java/datawave/webservice/query/runner/QueryExecutorBean.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/web-services/query/src/main/java/datawave/webservice/query/runner/QueryExecutorBean.java

      Lines 902 to 904 in 012eeed

      	response.addException(qe);
      	throw new BadRequestException(qe, response);
      	} catch (Exception e) {

      
        
    • Target Code : NationalSecurityAgency-datawave/web-services/query/src/main/java/datawave/webservice/query/runner/QueryExecutorBean.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/web-services/query/src/main/java/datawave/webservice/query/runner/QueryExecutorBean.java

      Lines 736 to 738 in 012eeed

      	response.addException(qe);
      	throw qe;
      	}

      
        
    • Target Code : NationalSecurityAgency-datawave/web-services/query/src/main/java/datawave/webservice/query/runner/QueryExecutorBean.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/web-services/query/src/main/java/datawave/webservice/query/runner/QueryExecutorBean.java

      Lines 731 to 733 in 012eeed

      	response.addException(qe);
      	throw new BadRequestException(qe, response);
      	} catch (Exception e) {

      
        
    • Target Code : NationalSecurityAgency-datawave/web-services/map-reduce/src/main/java/datawave/webservice/mr/MapReduceBean.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/web-services/map-reduce/src/main/java/datawave/webservice/mr/MapReduceBean.java

      Lines 309 to 311 in 012eeed

      	response.addMessage("Error auditing query - " + e.getMessage());
      	throw new BadRequestException(e, response);
      	}

      
        
    • Target Code : NationalSecurityAgency-datawave/web-services/map-reduce/src/main/java/datawave/webservice/mr/MapReduceBean.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/web-services/map-reduce/src/main/java/datawave/webservice/mr/MapReduceBean.java

      Lines 305 to 307 in 012eeed

      	response.addException(qe);
      	throw new BadRequestException(qe, response);
      	} catch (Exception e) {

      
        
    • Target Code : NationalSecurityAgency-datawave/warehouse/ingest-core/src/main/java/datawave/ingest/util/NGramTokenizationStrategy.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/ingest-core/src/main/java/datawave/ingest/util/NGramTokenizationStrategy.java

      Lines 171 to 173 in 012eeed

      	if (null == exception) {
      	throw new TokenizationException(e);
      	}

      
        
    • Target Code : NationalSecurityAgency-datawave/warehouse/query-core/src/main/java/datawave/query/tables/ScannerSession.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/query-core/src/main/java/datawave/query/tables/ScannerSession.java

      Lines 390 to 392 in 012eeed

      	log.error("Exception discovered on next call", uncaughtExceptionHandler.getThrowable());
      	throw new RuntimeException(uncaughtExceptionHandler.getThrowable());
      	}

      
        
    • Target Code : NationalSecurityAgency-datawave/warehouse/query-core/src/main/java/datawave/query/tables/ScannerSession.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/query-core/src/main/java/datawave/query/tables/ScannerSession.java

      Lines 348 to 350 in 012eeed

      	log.error("Exception discovered on hasNext call", uncaughtExceptionHandler.getThrowable());
      	throw new RuntimeException(uncaughtExceptionHandler.getThrowable());
      	}

      
        

• Save and re-use this "Random".

  • Description : https://rules.sonarsource.com/java/RSPEC-2119/
    • Target Code : NationalSecurityAgency-datawave/warehouse/age-off/src/test/java/datawave/iterators/filter/TokenTtlTrieTest.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/age-off/src/test/java/datawave/iterators/filter/TokenTtlTrieTest.java

      Lines 91 to 93 in 012eeed

      	List<Long> trieEntries = new ArrayList<>();
      	Random r = new Random();
      	TokenTtlTrie.Builder builder = new TokenTtlTrie.Builder().setDelimiters(",;".getBytes());

      
        
    • Target Code : NationalSecurityAgency-datawave/warehouse/accumulo-extensions/src/test/java/datawave/ingest/table/balancer/ShardedTableTabletBalancerTest.java [view change history] [ignore this]
      

      NationalSecurityAgency-datawave/warehouse/accumulo-extensions/src/test/java/datawave/ingest/table/balancer/ShardedTableTabletBalancerTest.java

      Lines 60 to 62 in 012eeed

      	private TestShardedTableTabletBalancer testBalancer;
      	private long randomSeed = new Random().nextLong();